From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH RFC 2/5] blkif: document new blkback path xenstore node Date: Mon, 1 Jun 2015 14:24:05 +0100 Message-ID: <20150601132405.GG19403@zion.uk.xensource.com> References: <1432286338-56077-1-git-send-email-roger.pau@citrix.com> <1432286338-56077-3-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YzPhQ-0002OY-6d for xen-devel@lists.xenproject.org; Mon, 01 Jun 2015 13:24:16 +0000 Content-Disposition: inline In-Reply-To: <1432286338-56077-3-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne Cc: wei.liu2@citrix.com, Ian Campbell , Ian Jackson , Tim Deegan , Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Fri, May 22, 2015 at 11:18:55AM +0200, Roger Pau Monne wrote: > FreeBSD blkback uses the path xenstore node in order to fetch the path to > the underlying backing storage (either a block device or raw image). This > node is set by the hotplug scripts. > = > Signed-off-by: Roger Pau Monn=E9 > Cc: Ian Campbell > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Tim Deegan > --- > xen/include/public/io/blkif.h | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > = > diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h > index 6baf7fb..b1e2245 100644 > --- a/xen/include/public/io/blkif.h > +++ b/xen/include/public/io/blkif.h > @@ -89,8 +89,15 @@ > * Values: string > * > * A free formatted string providing sufficient information for the > - * backend driver to open the backing device. (e.g. the path to the > - * file or block device representing the backing store.) > + * hotplug script to attach the device and provide a suitable > + * handler (ie: a block device) for blkback to use. > + * > + * path > + * Values: string > + * Notes: 11 > + * > + * A free formatted string that contains the path to the backing de= vice > + * for this blkback instance. Why can't FreeBSD use the same "physical-device" node as Linux and NetBSD do? AIUI from reading this doc "physical-device" node already covers both "file" and "block device", i.e. it's a superset of the proposed "path" node here. Wei. > * > * type > * Values: "file", "phy", "tap" > @@ -385,6 +392,7 @@ > * than RING_SIZE * BLKIF_MAX_SEGMENTS_PER_REQUEST. > *(10) The discard-secure property may be present and will be set to 1 i= f the > * backing device supports secure discard. > + *(11) This node is only present on FreeBSD. > */ > = > /* > -- = > 1.9.5 (Apple Git-50.3) > = > = > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel