From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759234AbbFBOPg (ORCPT ); Tue, 2 Jun 2015 10:15:36 -0400 Received: from smtprelay0170.hostedemail.com ([216.40.44.170]:53493 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758542AbbFBOP1 (ORCPT ); Tue, 2 Jun 2015 10:15:27 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:979:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3873:3874:4321:4383:5007:6119:6261:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12043:12517:12519:12555:12663:12740:13069:13311:13357:14093:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: skate97_4c7c225343356 X-Filterd-Recvd-Size: 2395 Date: Tue, 2 Jun 2015 10:15:16 -0400 From: Steven Rostedt To: Gil Fruchter Cc: , , , , Subject: Re: [PATCH 1/2] tracing: Prefer kcalloc over kzalloc with multiply Message-ID: <20150602101516.7dd2feb6@gandalf.local.home> In-Reply-To: <1433251589-21013-2-git-send-email-gilf@ezchip.com> References: <1433251589-21013-1-git-send-email-gilf@ezchip.com> <1433251589-21013-2-git-send-email-gilf@ezchip.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Jun 2015 16:26:28 +0300 Gil Fruchter wrote: > fix checkpatch warning for using kzalloc with multiply: > WARNING: Prefer kcalloc over kzalloc with multiply > + iter->buffer_iter = kzalloc(sizeof(*iter->buffer_iter) > * num_possible_cpus(), I'm not against applying this patch, but "fix checkpatch warning" is never rational for a change. This should say something like, "Use kcalloc for allocating an array instead of a simple multiplier with kzalloc, as that is what kcalloc is used for." In other words, if checkpatch found something that should be change, have the change log tell us why it should be changed. You can than add a "Found with checkpatch" to give checkpatch the credit. -- Steve > > Signed-off-by: Gil Fruchter > --- > kernel/trace/trace.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index 0533049..57ffc4a 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -3034,7 +3034,7 @@ __tracing_open(struct inode *inode, struct file *file, bool snapshot) > if (!iter) > return ERR_PTR(-ENOMEM); > > - iter->buffer_iter = kzalloc(sizeof(*iter->buffer_iter) * num_possible_cpus(), > + iter->buffer_iter = kcalloc(num_possible_cpus(), sizeof(*iter->buffer_iter), > GFP_KERNEL); > if (!iter->buffer_iter) > goto release;