From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH RFC 2/5] blkif: document new blkback path xenstore node Date: Tue, 2 Jun 2015 17:57:24 +0100 Message-ID: <20150602165723.GY19403@zion.uk.xensource.com> References: <1432286338-56077-1-git-send-email-roger.pau@citrix.com> <1432286338-56077-3-git-send-email-roger.pau@citrix.com> <20150601132405.GG19403@zion.uk.xensource.com> <556DCA1C.4040606@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YzpVJ-0008DA-FT for xen-devel@lists.xenproject.org; Tue, 02 Jun 2015 16:57:29 +0000 Content-Disposition: inline In-Reply-To: <556DCA1C.4040606@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: Wei Liu , Ian Campbell , Tim Deegan , Ian Jackson , Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Tue, Jun 02, 2015 at 05:22:04PM +0200, Roger Pau Monn=E9 wrote: > El 01/06/15 a les 15.24, Wei Liu ha escrit: > > On Fri, May 22, 2015 at 11:18:55AM +0200, Roger Pau Monne wrote: > >> FreeBSD blkback uses the path xenstore node in order to fetch the path= to > >> the underlying backing storage (either a block device or raw image). T= his > >> node is set by the hotplug scripts. > >> > >> Signed-off-by: Roger Pau Monn=E9 > >> Cc: Ian Campbell > >> Cc: Ian Jackson > >> Cc: Jan Beulich > >> Cc: Tim Deegan > >> --- > >> xen/include/public/io/blkif.h | 12 ++++++++++-- > >> 1 file changed, 10 insertions(+), 2 deletions(-) > >> > >> diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blk= if.h > >> index 6baf7fb..b1e2245 100644 > >> --- a/xen/include/public/io/blkif.h > >> +++ b/xen/include/public/io/blkif.h > >> @@ -89,8 +89,15 @@ > >> * Values: string > >> * > >> * A free formatted string providing sufficient information for = the > >> - * backend driver to open the backing device. (e.g. the path to= the > >> - * file or block device representing the backing store.) > >> + * hotplug script to attach the device and provide a suitable > >> + * handler (ie: a block device) for blkback to use. > >> + * > >> + * path > >> + * Values: string > >> + * Notes: 11 > >> + * > >> + * A free formatted string that contains the path to the backing= device > >> + * for this blkback instance. > > = > > Why can't FreeBSD use the same "physical-device" node as Linux and > > NetBSD do? AIUI from reading this doc "physical-device" node already > > covers both "file" and "block device", i.e. it's a superset of the > > proposed "path" node here. > = > Not sure why, but "physical-device" is not documented at all in blkif.h. > = Er... > I don't mind using the "physical-device" node, it's just that both Linux > and NetBSD use it to store the block device major and minor numbers, and > FreeBSD instead needs to store an absolute path (to either a block or > regular file). If people think it's fine to have different formats for > "physical-device" depending on the underlying OS I don't mind using it > on FreeBSD also. > = I think you can just document it and claim it your own pet node. :-) I don't have much say in this field. I'm fine with anything that's clearly documented. Wei. > Roger.