From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH v2 06/10] drm: Avoid atomic commit path for CRTC property (Gamma) Date: Mon, 8 Jun 2015 17:58:23 -0700 Message-ID: <20150609005823.GC7449@intel.com> References: <1433425361-17864-1-git-send-email-Kausal.Malladi@intel.com> <1433425361-17864-7-git-send-email-Kausal.Malladi@intel.com> <20150606010102.GI1099@intel.com> <5572E1DD.5020809@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <5572E1DD.5020809@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Sharma, Shashank" Cc: annie.j.matheson@intel.com, dhanya.p.r@intel.com, dri-devel@lists.freedesktop.org, vijay.a.purushothaman@intel.com, Kausal Malladi , jesse.barnes@intel.com, daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBKdW4gMDYsIDIwMTUgYXQgMDU6MzQ6NDVQTSArMDUzMCwgU2hhcm1hLCBTaGFzaGFu ayB3cm90ZToKPiBSZWdhcmRzCj4gU2hhc2hhbmsKPiAKPiBPbiA2LzYvMjAxNSA2OjMxIEFNLCBN YXR0IFJvcGVyIHdyb3RlOgo+ID5PbiBUaHUsIEp1biAwNCwgMjAxNSBhdCAwNzoxMjozN1BNICsw NTMwLCBLYXVzYWwgTWFsbGFkaSB3cm90ZToKPiA+PkZyb206IEthdXNhbCBNYWxsYWRpIDxLYXVz YWwuTWFsbGFkaUBpbnRlbC5jb20+Cj4gPj4KPiA+PlRoZSBhdG9taWMgQ1JUQyBzZXQgaW5mcmFz dHJ1Y3R1cmUgaXMgbm90IGF2YWlsYWJsZSB5ZXQuIFNvLCB0aGUgYXRvbWljCj4gPj5jaGVjayBw YXRoIHRocm93cyBlcnJvciBmb3IgYW55IG5vbi1wbGFuZSBwcm9wZXJ0eS4KPiA+Pgo+ID4+VGhp cyBwYXRjaCBhZGRzIGEgZGl2ZXJzaW9uIHRvIGF2b2lkIGNvbW1pdCBwYXRoIGZvciBEUk0gYXRv bWljIHNldCBHYW1tYQo+ID4+cHJvcGVydHksIHVudGlsIGF0b21pYyBDUlRDIGluZnJhc3RydWN0 dXJlIGlzIHJlYWR5Lgo+ID4KPiA+VGhpcyBkb2Vzbid0IGxvb2sgcmlnaHQsIGJ1dCBJIGRvbid0 IHF1aXRlIHVuZGVyc3RhbmQgd2hhdCB5b3UncmUgdHJ5aW5nCj4gPnRvIGRvIGZyb20gdGhlIGNv bW1pdCBtZXNzYWdlLgo+ID4KPiA+VGhpcyBmdW5jdGlvbiBpcyB3aGF0IHdpbGwgaW1wbGVtZW50 IGxlZ2FjeSBzZXRfcHJvcGVydHkgaW9jdGwncyBvZiBhCj4gPkNSVEMgb24gYW4gYXRvbWljLWJh c2VkIGRyaXZlci4gIFRoZSBpZGVhIGlzIHRoYXQgd2hlbiB0aGUgaW9jdGwgaXMKPiA+aXNzdWVk LCB3ZSBzaG91bGQgZ2V0IChpLmUuLCBtYWtlIGEgZHVwbGljYXRlIG9mKSB0aGUgY3VycmVudCBD UlRDCj4gPnN0YXRlLCBjaGFuZ2Ugc29tZSBvZiB0aGUgdmFsdWVzIGluIHRoYXQgc3RhdGUgKHdo aWNoIGlzIHdoYXQgdGhlCj4gPi5hdG9taWNfc2V0X3Byb3BlcnR5IGZ1bmN0aW9uIHRha2VzIGNh cmUgb2YpLCBhbmQgdGhlbiBzdWJtaXQgdGhhdAo+ID5tb2RpZmllZCBzdGF0ZSB0byB0aGUgZHJp dmVyIGZvciBjaGVja2luZyBhbmQgaHctcHJvZ3JhbW1pbmcuCj4gPgo+ID5Pa2F5LCBJIGp1c3Qg dG9vayBhIHF1aWNrIHBlZWsgYWhlYWQgaW4geW91ciBwYXRjaCBzZXQgYW5kIEkgdGhpbmsgSQo+ ID51bmRlcnN0YW5kIHRoZSBjb25mdXNpb24gbm93Li4uaXQgbG9va3MgbGlrZSB5b3UncmUgdHJ5 aW5nIHRvIGFjdHVhbGx5Cj4gPnBlcmZvcm0gdGhlIGZ1bGwgaGFyZHdhcmUgdXBkYXRlIGluIHRo ZSAuYXRvbWljX3NldF9wcm9wZXJ0eSBjYWxsIGNoYWluLAo+ID53aGljaCBpc24ndCB3aGF0IHdl IHdhbnQgdG8gYmUgZG9pbmcgaW4gYW4gYXRvbWljIGRyaXZlci4KPiA+LmF0b21pY19zZXRfcHJv cGVydHkoKSBpcyBqdXN0IGEgbWF0dGVyIG9mIHVwZGF0aW5nIHRoZSBzdGF0ZSBzdHJ1Y3R1cmVz Cj4gPnRvIHJlZmxlY3QgdGhlIGNoYW5nZXMgeW91ICp3YW50KiB0byBtYWtlIChidXQgbm90IGFj dHVhbGx5IHBlcmZvcm1pbmcKPiA+dGhvc2UgY2hhbmdlcyByaWdodCBhd2F5KS4gIEl0IGlzbid0 IHVudGlsIGRybV9hdG9taWNfY29tbWl0KCkgZ2V0cwo+ID5jYWxsZWQgdGhhdCB3ZSB2YWxpZGF0 ZSB0aGUgbmV3IHN0YXRlIHN0cnVjdHVyZSBhbmQgdGhlbiB3cml0ZSBpdCB0byB0aGUKPiA+aGFy ZHdhcmUgaWYgaXQgbG9va3Mgb2theS4KPiA+Cj4gPktlZXAgaW4gbWluZCB0aGF0IHRoZSBvdmVy YWxsIGdvYWwgYmVoaW5kIGF0b21pYyBpcyB0aGF0IHdlIHdhbnQgdG8gYmUKPiA+YWJsZSB0byBz dXBwbHkgc2V2ZXJhbCBpdGVtcyB0byBiZSB1cGRhdGVkIChlLmcuLCBtb2RlLCBDU0MsIGdhbW1h LAo+ID5ldGMuKSB2aWEgdGhlIGF0b21pYyBpb2N0bCBhbmQgdGhlbiBoYXZlIHRoZW0gYWxsIGFj Y2VwdGVkIChhbmQKPiA+cHJvZ3JhbW1lZCkgYnkgdGhlIGRyaXZlciwgb3IgYWxsIHJlamVjdGVk IChzbyBub25lIGdldCBwcm9ncmFtbWVkKSBpZgo+ID5hbnkgb2YgdGhlbSBhcmUgaW52YWxpZC4g IEFsc28sIGlmIHRoZSBjb2xsZWN0aW9uIG9mIHByb3BlcnRpZXMgdGhhdAo+ID55b3UncmUgdXBk YXRpbmcgZmFsbCB3aXRoaW4gdGhlICJudWNsZWFyIHBhZ2VmbGlwIiBzdWJzZXQgb2YKPiA+ZnVu Y3Rpb25hbGl0eSwgeW91J2xsIGFsc28gZ2V0IGEgZ3VhcmFudGVlIHRoYXQgdGhvc2UgaXRlbXMg YWxsIGdldAo+ID51cGRhdGVkIHdpdGhpbiB0aGUgc2FtZSB2Ymxhbms7IHVwZGF0ZXMgdGhhdCBz dHJhZGRsZSBhIHZibGFuayBjb3VsZAo+ID5jYXVzZSB1bndhbnRlZCBmbGlja2VyaW5nIG9yIG90 aGVyIGFydGlmYWN0cy4gIFRoZSBoZWxwZXIgZnVuY3Rpb24KPiA+eW91J3JlIHVwZGF0aW5nIGhl cmUgb25seSBoYXBwZW5zIHRvIHVwZGF0ZSBhIHNpbmdsZSBzdGF0ZSB2YWx1ZSBhdCBhCj4gPnRp bWUsIGJ1dCB0aGUgc2FtZSAuYXRvbWljX3NldF9wcm9wZXJ0eSgpIGlzIGFsc28gdXNlZCBieSB0 aGUgYXRvbWljCj4gPmlvY3RsLCBzbyB3ZSBuZWVkIHRvIG1ha2Ugc3VyZSBpdCdzIGZvbGxvd2lu ZyB0aGUgZXhwZWN0ZWQgZGVzaWduLgo+ID4KPiA+RmluYWxseSwga2VlcCBpbiBtaW5kIHRoYXQg dGhlIGZ1bmN0aW9uIHlvdSdyZSB1cGRhdGluZyBoZXJlIGlzIGEgRFJNCj4gPmNvcmUgZnVuY3Rp b24uICBFdmVuIHRob3VnaCBpOTE1IGlzbid0IHF1aXRlIHJlYWR5IGZvciBmdWxsIGF0b21pYyB5 ZXQKPiA+YW5kIG1pZ2h0IGhhdmUgYSBiaXQgb2YgYnJhaW4gZGFtYWdlIGluIGFyZWFzLCBvdGhl ciB2ZW5kb3JzJyBkcml2ZXJzIGRvCj4gPmhhdmUgY29tcGxldGUgYXRvbWljIG1vZGVzZXR0aW5n IHN1cHBvcnQgKEkgdGhpbms/KSwgc28gYWRkaW5nCj4gPmk5MTUtc3BlY2lmaWMgd29ya2Fyb3Vu ZHMgbGlrZSB0aGlzIHRvIHRoZSBjb3JlIGZ1bmN0aW9uIGNvdWxkIGFjdHVhbGx5Cj4gPmhhbXBl ciB0aGVtLgo+ID4KPiA+Cj4gPk1hdHQKPiA+Cj4gSSB1bmRlcnN0b29kIHRoaXMgcG9pbnQuIEJ1 dCBpbiB0aGlzIGNhc2UsIHdlIHdpbGwgYmUgYmxvY2tlZCB1bnRpbAo+IHNldCBDUlRDIGltcGxl bWVudGF0aW9uIGNvbWVzIGluLiBDYW4geW91IHN1Z2dlc3QgYSBiZXR0ZXIgd2F5IHRvCj4gaGFu ZGxlIHRoaXMgd2l0aG91dCBnZXR0aW5nIGJsb2NrZWQgZm9yIHNldF9jcnRjKCkgPwoKSXMgdGhl IGZ1bmN0aW9uYWxpdHkgeW91IG5lZWQgc3RpbGwgbGFja2luZyB3aXRoIE1hYXJ0ZW4gTGFua2hv cnN0J3MKImNvbnZlcnQgdG8gYXRvbWljLCBwYXJ0IDIiIHNlcmllcyB0aGF0IHJlY2VudGx5IGxh bmRlZCB1cHN0cmVhbT8gIElmCnRoYXQgc2VyaWVzIGlzbid0IHN1ZmZpY2llbnQsIHRoZW0gSSdt IHByZXR0eSBzdXJlIHRoYXQgaGlzICJwYXJ0IDMiCnNlcmllcyBvbiB0aGUgbWFpbGluZyBsaXN0 IHdpbGwgZml4IGl0OyB0aGF0IHdpbGwgaG9wZWZ1bGx5IGJlIHJlYWR5IHRvCm1lcmdlIGFzIHNv b24gYXMgSSBnZXQgYSBjaGFuY2UgdG8gZG8gYSByZXZpZXcgb2YgaXQuCgpJJ2xsIGFkZCBNYWFy dGVuIHRvIHRoZSBDYyBoZXJlIGluIGNhc2UgaGUgd2FudHMgdG8gY29tbWVudC4uLgoKCk1hdHQK Cj4gPj4KPiA+PlNpZ25lZC1vZmYtYnk6IFNoYXNoYW5rIFNoYXJtYSA8c2hhc2hhbmsuc2hhcm1h QGludGVsLmNvbT4KPiA+PlNpZ25lZC1vZmYtYnk6IEthdXNhbCBNYWxsYWRpIDxLYXVzYWwuTWFs bGFkaUBpbnRlbC5jb20+Cj4gPj4tLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNf aGVscGVyLmMgfCAxNyArKysrKysrKysrKysrKy0tLQo+ID4+ICAxIGZpbGUgY2hhbmdlZCwgMTQg aW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+ZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9t aWNfaGVscGVyLmMKPiA+PmluZGV4IGE5MDA4NTguLjM3ZGJhNTUgMTAwNjQ0Cj4gPj4tLS0gYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ID4+KysrIGIvZHJpdmVycy9ncHUv ZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiA+PkBAIC0xNjk2LDYgKzE2OTYsOCBAQCBkcm1fYXRv bWljX2hlbHBlcl9jcnRjX3NldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gPj4g IHsKPiA+PiAgCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPiA+PiAgCXN0cnVjdCBk cm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiA+PisJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9 IGNydGMtPmRldjsKPiA+PisJc3RydWN0IGRybV9tb2RlX2NvbmZpZyAqY29uZmlnID0gJmRldi0+ bW9kZV9jb25maWc7Cj4gPj4gIAlpbnQgcmV0ID0gMDsKPiA+Pgo+ID4+ICAJc3RhdGUgPSBkcm1f YXRvbWljX3N0YXRlX2FsbG9jKGNydGMtPmRldik7Cj4gPj5AQCAtMTcxNiw5ICsxNzE4LDE4IEBA IHJldHJ5Ogo+ID4+ICAJaWYgKHJldCkKPiA+PiAgCQlnb3RvIGZhaWw7Cj4gPj4KPiA+Pi0JcmV0 ID0gZHJtX2F0b21pY19jb21taXQoc3RhdGUpOwo+ID4+LQlpZiAocmV0ICE9IDApCj4gPj4tCQln b3RvIGZhaWw7Cj4gPj4rCS8qKgo+ID4+KwkgKiBGSVhNRSA6IFRoaXMgaXMgYSBoYWNrLCB0byBh dm9pZCBhdG9taWMgY29tbWl0Cj4gPj4rCSAqIGZvciBDUlRDLCBiZWNhdXNlIGk5MTUgc3VwcG9y dHMgb25seQo+ID4+KwkgKiBhdG9taWMgcGxhbmUgb3BlcmF0aW9ucyBhdCB0aGUgbW9tZW50Cj4g Pj4rCSAqLwo+ID4+KwlpZiAocHJvcGVydHkgPT0gY29uZmlnLT5nYW1tYV9wcm9wZXJ0eSkKPiA+ PisJCXJldCA9IDA7Cj4gPj4rCWVsc2Ugewo+ID4+KwkJcmV0ID0gZHJtX2F0b21pY19jb21taXQo c3RhdGUpOwo+ID4+KwkJaWYgKHJldCAhPSAwKQo+ID4+KwkJCWdvdG8gZmFpbDsKPiA+PisJfQo+ ID4+Cj4gPj4gIAkvKiBEcml2ZXIgdGFrZXMgb3duZXJzaGlwIG9mIHN0YXRlIG9uIHN1Y2Nlc3Nm dWwgY29tbWl0LiAqLwo+ID4+ICAJcmV0dXJuIDA7Cj4gPj4tLQo+ID4+Mi40LjIKPiA+Pgo+ID4K Ci0tIApNYXR0IFJvcGVyCkdyYXBoaWNzIFNvZnR3YXJlIEVuZ2luZWVyCklvVEcgUGxhdGZvcm0g RW5hYmxpbmcgJiBEZXZlbG9wbWVudApJbnRlbCBDb3Jwb3JhdGlvbgooOTE2KSAzNTYtMjc5NQpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=