From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v5 04/10] test/hash: change order of loops in hash function tests Date: Wed, 10 Jun 2015 12:05:20 +0100 Message-ID: <20150610110520.GA6924@bricha3-MOBL3> References: <1431428560-25426-1-git-send-email-pablo.de.lara.guarch@intel.com> <1432289771-12799-1-git-send-email-pablo.de.lara.guarch@intel.com> <1432289771-12799-5-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Pablo de Lara Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 38E831DB1 for ; Wed, 10 Jun 2015 13:05:24 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1432289771-12799-5-git-send-email-pablo.de.lara.guarch@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 22, 2015 at 11:16:05AM +0100, Pablo de Lara wrote: > In order to see more clearly the performance difference > between different hash functions, order of the loops > have been changed, so it iterates first through initial values, > then key sizes and then the hash functions. > > Signed-off-by: Pablo de Lara > --- > app/test/test_hash_functions.c | 20 ++++++++++---------- > 1 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/app/test/test_hash_functions.c b/app/test/test_hash_functions.c > index 973fbe8..3b72e8f 100644 > --- a/app/test/test_hash_functions.c > +++ b/app/test/test_hash_functions.c > @@ -86,8 +86,8 @@ get_hash_name(rte_hash_function f) > * Test a hash function. > */ > static void > -run_hash_func_perf_test(rte_hash_function f, uint32_t init_val, > - uint32_t key_len) > +run_hash_func_perf_test(uint32_t key_len, uint32_t init_val, > + rte_hash_function f) > { > static uint8_t key[HASHTEST_ITERATIONS][RTE_HASH_KEY_LENGTH_MAX]; > uint64_t ticks, start, end; > @@ -122,17 +122,17 @@ run_hash_func_perf_tests(void) > printf("Hash Func. , Key Length (bytes), Initial value, Ticks/Op.\n"); > > for (i = 0; > - i < sizeof(hashtest_funcs) / sizeof(rte_hash_function); > + i < sizeof(hashtest_initvals) / sizeof(uint32_t); > i++) { > for (j = 0; > - j < sizeof(hashtest_initvals) / sizeof(uint32_t); > - j++) { > + j < sizeof(hashtest_key_lens) / sizeof(uint32_t); > + j++) { > for (k = 0; > - k < sizeof(hashtest_key_lens) / sizeof(uint32_t); > - k++) { These for loops should be changed to use RTE_DIM() macro when possible. It should allow each loop to just take up one line instead of three, as well as avoiding changes to the loops if the type of value ever changes from uint32_t. /Bruce