From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v5 06/10] hash: update jhash function with the latest available Date: Wed, 10 Jun 2015 12:07:38 +0100 Message-ID: <20150610110738.GB6924@bricha3-MOBL3> References: <1431428560-25426-1-git-send-email-pablo.de.lara.guarch@intel.com> <1432289771-12799-1-git-send-email-pablo.de.lara.guarch@intel.com> <1432289771-12799-7-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Pablo de Lara Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 76E9B5A9B for ; Wed, 10 Jun 2015 13:07:42 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1432289771-12799-7-git-send-email-pablo.de.lara.guarch@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 22, 2015 at 11:16:07AM +0100, Pablo de Lara wrote: > Jenkins hash function was developed originally in 1996, > and was integrated in first versions of DPDK. > The function has been improved in 2006, > achieving up to 60% better performance, compared to the original one. > > This patch integrates that code into the rte_jhash library. > It also updates the precalculated hash values in the unit test, > as the code now returns different values (expected) > This should be clearly called out in the release notes for 2.1. I don't expect that too many people are relying on the specific return values from the hash function, but just in case, we need to call this out. /Bruce