From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z328f-0006s8-2e for qemu-devel@nongnu.org; Thu, 11 Jun 2015 09:03:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z328X-0004vd-PA for qemu-devel@nongnu.org; Thu, 11 Jun 2015 09:03:20 -0400 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:33671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z328X-0004vP-HQ for qemu-devel@nongnu.org; Thu, 11 Jun 2015 09:03:13 -0400 Received: by wiwd19 with SMTP id d19so74150622wiw.0 for ; Thu, 11 Jun 2015 06:03:12 -0700 (PDT) Date: Thu, 11 Jun 2015 14:03:09 +0100 From: Stefan Hajnoczi Message-ID: <20150611130309.GD9425@stefanha-thinkpad.redhat.com> References: <1433776886-27239-1-git-send-email-vsementsov@virtuozzo.com> <1433776886-27239-2-git-send-email-vsementsov@virtuozzo.com> <20150609170325.GI3181@stefanha-thinkpad.redhat.com> <5577F312.9040502@virtuozzo.com> <20150610132420.GD2430@stefanha-thinkpad.home> <557960AC.4080607@virtuozzo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3Gf/FFewwPeBMqCJ" Content-Disposition: inline In-Reply-To: <557960AC.4080607@virtuozzo.com> Subject: Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy Cc: kwolf@redhat.com, qemu-devel@nongnu.org, Vladimir Sementsov-Ogievskiy , Stefan Hajnoczi , den@openvz.org, pbonzini@redhat.com, jsnow@redhat.com --3Gf/FFewwPeBMqCJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir Sementsov-Ogievskiy wrot= e: > On 10.06.2015 16:24, Stefan Hajnoczi wrote: > >On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy w= rote: > >>On 09.06.2015 20:03, Stefan Hajnoczi wrote: > >>>On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy= wrote: > >>>>@@ -166,6 +167,19 @@ the header extension data. Each entry look like = this: > >>>> terminated if it has full length) > >>>>+=3D=3D Dirty bitmaps =3D=3D > >>>>+ > >>>>+Dirty bitmaps is an optional header extension. It provides a possibi= lity of > >>>>+storing dirty bitmaps in qcow2 image. The fields are: > >>>>+ > >>>>+ 0 - 3: nb_dirty_bitmaps > >>>>+ Number of dirty bitmaps contained in the image > >>>Is there a maximum? > >>hmm. any proposals for this? > >65535 seems practical. >=20 > So, you suggest to reduce this field width to 2b? And additional 2 bytes > reserved field, to achieve 8b-alignment? No, I would leave it 32-bit but impose a little (which can be increased later if necessary). That's how nb_snapshots works too. --3Gf/FFewwPeBMqCJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVeYcNAAoJEJykq7OBq3PITnUH/j4jDrdhDheO7AAumNBwMBk5 Zxxx/o4phkBvE+K16Cx5XPCKFWn50Sfck8y/WODmcibG/l9FkueBOBbKNBrTGsx6 bko8ViY4WIEqK6vrbEhOXpMhWWvkZb3YmZrFiAp5kd8PEJuks65Jm4CinbVGLGNa sgQNFqYNOPlogXTFjOUq6684K8bMabGwStqrtR4KHpCqLvtC8AGlzkzG7i/GpXDN CJk4VXbzi3XbZxnPJG9ivt8l/kzYfocu8djc9pbFi7FhB0WI8wKqiQM9dXMD9hAZ 7f4Sj//RzsgtMNJVTGlbpmgzcq9Muki2Xa4oihuGfru4WCwOwvw0HSQmZwD2NB4= =/9gG -----END PGP SIGNATURE----- --3Gf/FFewwPeBMqCJ--