From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH V4 1/7] libxl: export some functions for pvusb use Date: Thu, 11 Jun 2015 17:28:39 +0100 Message-ID: <20150611162839.GL14606@zion.uk.xensource.com> References: <1433906441-3280-1-git-send-email-cyliu@suse.com> <1433906441-3280-2-git-send-email-cyliu@suse.com> <21881.45721.649328.6336@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <21881.45721.649328.6336@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, george.dunlap@eu.citrix.com, Chunyan Liu , xen-devel@lists.xen.org, Simon Cao List-Id: xen-devel@lists.xenproject.org On Thu, Jun 11, 2015 at 05:08:57PM +0100, Ian Jackson wrote: > Chunyan Liu writes ("[Xen-devel] [PATCH V4 1/7] libxl: export some functions for pvusb use"): > > Signed-off-by: Chunyan Liu > > Signed-off-by: Simon Cao > > Acked-by: Wei Liu > ... > > /* generic callback for devices that only need to set ao_complete */ > > -static void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device *aodev) > > +void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device *aodev) > > Functions in libxl with external linkage should have the appropriate > namespacing (ie, their names must start with libxl__). > > So, I'm afraid, contrary to Wei's opinion: > > Nacked-by: Ian Jackson > I think if Chunyan moves that function to libxl__ namespace this patch should be fine, right? Wei. > Ian.