From: Greg KH <gregkh@linuxfoundation.org>
To: David Kershner <david.kershner@unisys.com>
Cc: Jes.Sorensen@redhat.com, sParMaintainer@unisys.com,
driverdev-devel@linuxdriverproject.org,
Benjamin.Romer@unisys.com
Subject: Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed
Date: Fri, 12 Jun 2015 17:07:55 -0700 [thread overview]
Message-ID: <20150613000755.GA5877@kroah.com> (raw)
In-Reply-To: <1434141968-4133-3-git-send-email-david.kershner@unisys.com>
On Fri, Jun 12, 2015 at 04:46:07PM -0400, David Kershner wrote:
> It was noticed that iochannel.h was still using pragmas to
> pack the datastructures, should be using __packed instead.
>
> Signed-off-by: David Kershner <david.kershner@unisys.com>
> ---
> drivers/staging/unisys/include/iochannel.h | 45 ++++++++++++------------------
> 1 file changed, 18 insertions(+), 27 deletions(-)
Other .h files also are like this in the driver, you should fix them up
as well in future patches.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2015-06-13 0:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 20:46 [PATCH v2 0/3] staging: unisys: visorbus fixes David Kershner
2015-06-12 20:46 ` [PATCH v2 1/3] staging: unisys: Move phys_info to iochannel.h David Kershner
2015-06-12 20:46 ` [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed David Kershner
2015-06-13 0:07 ` Greg KH [this message]
2015-06-19 12:55 ` Dan Carpenter
2015-06-19 15:02 ` Kershner, David A
2015-06-19 15:08 ` Jes Sorensen
2015-06-19 19:11 ` Dan Carpenter
2015-06-12 20:46 ` [PATCH v2 3/3] staging: unisys: Don't hold device responses until driver loads David Kershner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150613000755.GA5877@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Benjamin.Romer@unisys.com \
--cc=Jes.Sorensen@redhat.com \
--cc=david.kershner@unisys.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=sParMaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.