From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752079AbbFOWcK (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Jun 2015 18:32:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58540 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750911AbbFOWcD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Jun 2015 18:32:03 -0400
Date: Tue, 16 Jun 2015 00:30:56 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Kees Cook <keescook@chromium.org>
Cc: Tycho Andersen <tycho.andersen@canonical.com>,
        Andy Lutomirski <luto@amacapital.net>, Will Drewry <wad@chromium.org>,
        Roland McGrath <roland@hack.frob.com>,
        Pavel Emelyanov <xemul@parallels.com>,
        "Serge E. Hallyn" <serge.hallyn@ubuntu.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [kees:seccomp/tip 2/2] kernel/ptrace.c:567:3: note: in
	expansion of macro 'if'
Message-ID: <20150615223056.GA18897@redhat.com>
References: <201506160626.KppQbBQV%fengguang.wu@intel.com> <CAGXu5j+1TXE3MzbrAu=0hHgmk4nfndQxZPzi7R+oKigP21pH9Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGXu5j+1TXE3MzbrAu=0hHgmk4nfndQxZPzi7R+oKigP21pH9Q@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/15, Kees Cook wrote:
>
> Looks like dead-code elimination happens after structures are
> accessed, so this needs to use the accessor.

Ah, I forgot we have the dummy "struct seccomp { }" for SECCOMP=n

> Sorry I missed this
> earlier!

Me too :/

Oleg.