From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756964AbbFPJVz (ORCPT ); Tue, 16 Jun 2015 05:21:55 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:49676 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756832AbbFPJVr (ORCPT ); Tue, 16 Jun 2015 05:21:47 -0400 Date: Tue, 16 Jun 2015 11:21:36 +0200 From: Peter Zijlstra To: Imre Palik Cc: Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, "Palik, Imre" , Anthony Liguori Subject: Re: [PATCH v3] perf: honoring the architectural performance monitoring version Message-ID: <20150616092136.GL3644@twins.programming.kicks-ass.net> References: <1434378152-4042-1-git-send-email-imrep.amz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434378152-4042-1-git-send-email-imrep.amz@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2015 at 04:22:32PM +0200, Imre Palik wrote: > From: "Palik, Imre" > > Architectural performance monitoring version 1 doesn't support fixed > counters. Currently, even if a hypervisor advertises support for > architectural performance monitoring version 1, perf may still tries to use > the fixed counters, as the constraints are set up based on the CPU model. > > This patch ensures that perf honors the architectural performance > monitoring version returned by CPUID, and it only uses the fixed counters > for version two and above. > > Some of the ideas in this patch are coming from Peter Zijlstra. What's the difference from -v2? I'm not really seeing it.