From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58789)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <drjones@redhat.com>) id 1Z4qfW-0004Pr-Er
	for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:12:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <drjones@redhat.com>) id 1Z4qfT-0004bl-73
	for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:12:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44070)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <drjones@redhat.com>) id 1Z4qfT-0004bZ-1U
	for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:12:43 -0400
Date: Tue, 16 Jun 2015 15:12:37 +0200
From: Andrew Jones <drjones@redhat.com>
Message-ID: <20150616131237.GF4428@hawk.localdomain>
References: <1428670681-23032-1-git-send-email-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1428670681-23032-1-git-send-email-peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH for-2.3] Revert seccomp tests that allow it
 to be used on non-x86 architectures
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Marcus Meissner <meissner@suse.de>, Eduardo Otubo <eduardo.otubo@profitbricks.com>, patches@linaro.org, Riku Voipio <riku.voipio@iki.fi>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Paul Moore <pmoore@redhat.com>, Karl-Philipp Richter <krichter722@aol.de>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>

On Fri, Apr 10, 2015 at 01:58:01PM +0100, Peter Maydell wrote:
> Unfortunately it turns out that libseccomp 2.2 still does not work
> correctly on non-x86 architectures; return to the previous configure
> setup of insisting on libseccomp 2.1 or better and i386/x86_64 and
> disabling seccomp support in all other situations.
> 
> This reverts the two commits:
>  * "seccomp: libseccomp version varying according to arch"
>    (commit 896848f0d3e2393905845ef2b244bb2601f9df0c)
>  * "seccomp: update libseccomp version and remove arch restriction"
>    (commit 8e27fc200457e3f2473d0069263774d4ba17bd85)
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> With QEMU 2.3 release so close this seems the safest approach.
> 
>  configure | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/configure b/configure
> index 8b673fd..6969f6f 100755
> --- a/configure
> +++ b/configure
> @@ -1848,19 +1848,14 @@ fi
>  # libseccomp check
>  
>  if test "$seccomp" != "no" ; then
> -    if $pkg_config --atleast-version=2.2.0 libseccomp ||
> -        (test "$cpu" = "i386" || test "$cpu" = "x86_64" &&
> -        $pkg_config --atleast-version=2.1.1 libseccomp); then
> +    if test "$cpu" = "i386" || test "$cpu" = "x86_64" &&
> +        $pkg_config --atleast-version=2.1.1 libseccomp; then
>          libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
>          QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"
>  	seccomp="yes"
>      else
>  	if test "$seccomp" = "yes"; then
> -        if test "$cpu" = "i386" || test "$cpu" = "x86_64"; then
>              feature_not_found "libseccomp" "Install libseccomp devel >= 2.1.1"
> -        else
> -            feature_not_found "libseccomp" "Install libseccomp devel >= 2.2.0"
> -        fi
>  	fi
>  	seccomp="no"
>      fi
> -- 
> 1.9.1
> 
> 
>

Hi Peter,

Can we now revert this revert, along with bumping the non-x86 arch
atleast-version to v2.2.1?

Thanks,
drew