* [PATCH] Input: pixcir_i2c_ts - fix receive error
@ 2015-06-16 20:03 Frodo Lai
2015-06-16 22:07 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Frodo Lai @ 2015-06-16 20:03 UTC (permalink / raw
To: dmitry.torokhov; +Cc: rogerq, rydberg, jg1.han, linux-input, linux-kernel
The i2c_master_recv() uses readsize to receive data from i2c but
compares to size of rdbuf which is always 27. This would casue
problem when the max_fingers is not 5. Change the comparison value
to readsize instead.
Signed-off-by: Frodo Lai <frodo_lai@bcmcom.com>
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
index 2c21071..8f3e243 100644
--- a/drivers/input/touchscreen/pixcir_i2c_ts.c
+++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
@@ -78,7 +78,7 @@ static void pixcir_ts_parse(struct pixcir_i2c_ts_data *tsdata,
}
ret = i2c_master_recv(tsdata->client, rdbuf, readsize);
- if (ret != sizeof(rdbuf)) {
+ if (ret != readsize) {
dev_err(&tsdata->client->dev,
"%s: i2c_master_recv failed(), ret=%d\n",
__func__, ret);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: pixcir_i2c_ts - fix receive error
2015-06-16 20:03 [PATCH] Input: pixcir_i2c_ts - fix receive error Frodo Lai
@ 2015-06-16 22:07 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2015-06-16 22:07 UTC (permalink / raw
To: Frodo Lai; +Cc: rogerq, rydberg, jg1.han, linux-input, linux-kernel
On Tue, Jun 16, 2015 at 01:03:04PM -0700, Frodo Lai wrote:
> The i2c_master_recv() uses readsize to receive data from i2c but
> compares to size of rdbuf which is always 27. This would casue
> problem when the max_fingers is not 5. Change the comparison value
> to readsize instead.
>
> Signed-off-by: Frodo Lai <frodo_lai@bcmcom.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
> index 2c21071..8f3e243 100644
> --- a/drivers/input/touchscreen/pixcir_i2c_ts.c
> +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
> @@ -78,7 +78,7 @@ static void pixcir_ts_parse(struct pixcir_i2c_ts_data *tsdata,
> }
>
> ret = i2c_master_recv(tsdata->client, rdbuf, readsize);
> - if (ret != sizeof(rdbuf)) {
> + if (ret != readsize) {
> dev_err(&tsdata->client->dev,
> "%s: i2c_master_recv failed(), ret=%d\n",
> __func__, ret);
> --
> 1.7.9.5
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-16 22:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-16 20:03 [PATCH] Input: pixcir_i2c_ts - fix receive error Frodo Lai
2015-06-16 22:07 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.