All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Thomas de Beauchene <thomas.chauvot-de-beauchene@epitech.eu>
Cc: <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Thomas de Beauchene <chauvo_t@epitech.eu>,
	Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] Documentation: filesystems: updated struct inode_operations documentation in vfs.txt
Date: Wed, 17 Jun 2015 08:54:07 -0600	[thread overview]
Message-ID: <20150617085407.69df0468@lwn.net> (raw)
In-Reply-To: <1434552395-31715-1-git-send-email-thomas.chauvot-de-beauchene@epitech.eu>

On Wed, 17 Jun 2015 16:46:35 +0200
Thomas de Beauchene <thomas.chauvot-de-beauchene@epitech.eu> wrote:

> Updated struct inode_operations documentation in vfs.txt to match
> current implementation

Looks good at a first glance, will probably queue it later.  But please be
sure to CC Al Viro (added) on patches like this; he's the expert in this
area.

Thanks,

jon

> Signed-off-by: Thomas de Beauchene <chauvo_t@epitech.eu>
> ---
>  Documentation/filesystems/vfs.txt | 30 +++++++++++++++++++-----------
>  1 file changed, 19 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/filesystems/vfs.txt b/Documentation/filesystems/vfs.txt
> index 3cb2ccf..ff53e34 100644
> --- a/Documentation/filesystems/vfs.txt
> +++ b/Documentation/filesystems/vfs.txt
> @@ -341,11 +341,18 @@ struct inode_operations
>  -----------------------
>  
>  This describes how the VFS can manipulate an inode in your
> -filesystem. As of kernel 2.6.22, the following members are defined:
> +filesystem. As of kernel 4.1, the following members are defined:
>  
>  struct inode_operations {
> -	int (*create) (struct inode *,struct dentry *, umode_t, bool);
>  	struct dentry * (*lookup) (struct inode *,struct dentry *, unsigned int);
> +	void * (*follow_link) (struct dentry *, struct nameidata *);
> +	int (*permission) (struct inode *, int);
> +	struct posix_acl * (*get_acl)(struct inode *, int);
> +
> +	int (*readlink) (struct dentry *, char __user *,int);
> +	void (*put_link) (struct dentry *, struct nameidata *, void *);
> +
> +	int (*create) (struct inode *,struct dentry *, umode_t, bool);
>  	int (*link) (struct dentry *,struct inode *,struct dentry *);
>  	int (*unlink) (struct inode *,struct dentry *);
>  	int (*symlink) (struct inode *,struct dentry *,const char *);
> @@ -356,23 +363,24 @@ struct inode_operations {
>  			struct inode *, struct dentry *);
>  	int (*rename2) (struct inode *, struct dentry *,
>  			struct inode *, struct dentry *, unsigned int);
> -	int (*readlink) (struct dentry *, char __user *,int);
> -        void * (*follow_link) (struct dentry *, struct nameidata *);
> -        void (*put_link) (struct dentry *, struct nameidata *, void *);
> -	int (*permission) (struct inode *, int);
> -	int (*get_acl)(struct inode *, int);
>  	int (*setattr) (struct dentry *, struct iattr *);
>  	int (*getattr) (struct vfsmount *mnt, struct dentry *, struct kstat *);
>  	int (*setxattr) (struct dentry *, const char *,const void *,size_t,int);
>  	ssize_t (*getxattr) (struct dentry *, const char *, void *, size_t);
>  	ssize_t (*listxattr) (struct dentry *, char *, size_t);
>  	int (*removexattr) (struct dentry *, const char *);
> -	void (*update_time)(struct inode *, struct timespec *, int);
> -	int (*atomic_open)(struct inode *, struct dentry *, struct file *,
> -			unsigned open_flag, umode_t create_mode, int *opened);
> +	int (*fiemap)(struct inode *, struct fiemap_extent_info *, u64 start,
> +		      u64 len);
> +	int (*update_time)(struct inode *, struct timespec *, int);
> +	int (*atomic_open)(struct inode *, struct dentry *,
> +			   struct file *, unsigned open_flag,
> +			   umode_t create_mode, int *opened);
>  	int (*tmpfile) (struct inode *, struct dentry *, umode_t);
> +	int (*set_acl)(struct inode *, struct posix_acl *, int);
> +
> +	/* WARNING: probably going away soon, do not use! */
>  	int (*dentry_open)(struct dentry *, struct file *, const struct cred *);
> -};
> +} ____cacheline_aligned;
>  
>  Again, all methods are called without any locks being held, unless
>  otherwise noted.

  reply	other threads:[~2015-06-17 14:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 14:46 [PATCH] Documentation: filesystems: updated struct inode_operations documentation in vfs.txt Thomas de Beauchene
2015-06-17 14:54 ` Jonathan Corbet [this message]
2015-06-17 15:04   ` Al Viro
2015-06-22 16:13 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150617085407.69df0468@lwn.net \
    --to=corbet@lwn.net \
    --cc=chauvo_t@epitech.eu \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.chauvot-de-beauchene@epitech.eu \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.