From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z59FY-0001up-E4 for qemu-devel@nongnu.org; Wed, 17 Jun 2015 05:03:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z59FS-0004hs-Ig for qemu-devel@nongnu.org; Wed, 17 Jun 2015 05:03:12 -0400 Date: Wed, 17 Jun 2015 11:02:55 +0200 From: Kevin Wolf Message-ID: <20150617090255.GB4202@noname.str.redhat.com> References: <06990ada8a0d0beb9bb942b5b9ddc1c19a9a4664.1434458391.git.DirtY.iCE.hu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <06990ada8a0d0beb9bb942b5b9ddc1c19a9a4664.1434458391.git.DirtY.iCE.hu@gmail.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/6] opts: do not print separator before first item in qemu_opts_print List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?B?S8WRdsOhZ8OzLCBab2x0w6Fu?= Cc: qemu-devel@nongnu.org, "open list:Block layer core" , Gerd Hoffmann Am 16.06.2015 um 14:49 hat K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n geschrieben= : > This allows to print options in a format that the user would actually w= rite it > on the command line (foo=3Dbar,baz=3Dasd,etc=3Ddef), without prepending= a spurious > comma at the beginning of the list. Note that if you really want to produce a valid command line, you would have to escape any commas in option values. The quotes arounds strings might not be wanted any more then either. > Only block.c depended on the old behavior, but it was also updated. >=20 > Signed-off-by: K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n Seems that no behaviour changes from a block layer perspective, so: Acked-by: Kevin Wolf