From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754946AbbFQJmi (ORCPT ); Wed, 17 Jun 2015 05:42:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59629 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794AbbFQJm3 (ORCPT ); Wed, 17 Jun 2015 05:42:29 -0400 Date: Wed, 17 Jun 2015 11:42:26 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: x86@kernel.org, Peter Zijlstra , John Stultz , linux-kernel@vger.kernel.org, Len Brown , Huang Rui , Denys Vlasenko , kvm@vger.kernel.org, Ralf Baechle Subject: Re: [PATCH v3 02/18] x86/msr/kvm: Remove vget_cycles() Message-ID: <20150617094226.GC26661@pd.tnic> References: <20615df14ae2eb713ea7a5f5123c1dc4c7ca993d.1434501121.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20615df14ae2eb713ea7a5f5123c1dc4c7ca993d.1434501121.git.luto@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2015 at 05:35:50PM -0700, Andy Lutomirski wrote: > The only caller was kvm's read_tsc. The only difference between > vget_cycles and native_read_tsc was that vget_cycles returned zero > instead of crashing on TSC-less systems. KVM's already checks > vclock_mode before calling that function, so the extra check is > unnecessary. > > (Off-topic, but the whole KVM clock host implementation is gross. > IMO it should be rewritten.) > > Signed-off-by: Andy Lutomirski > --- > arch/x86/include/asm/tsc.h | 13 ------------- > arch/x86/kvm/x86.c | 2 +- > 2 files changed, 1 insertion(+), 14 deletions(-) Acked-by: Borislav Petkov -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --