From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754763AbbFQLbE (ORCPT ); Wed, 17 Jun 2015 07:31:04 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:33616 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366AbbFQLbB (ORCPT ); Wed, 17 Jun 2015 07:31:01 -0400 Date: Wed, 17 Jun 2015 17:00:50 +0530 From: Sudip Mukherjee To: Joe Perches Cc: Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] staging: sm7xxfb: move mode table Message-ID: <20150617113050.GA8337@sudip-PC> References: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com> <1434462131-15191-7-git-send-email-sudipm.mukherjee@gmail.com> <1434476037.2689.1.camel@perches.com> <20150617081522.GB13043@sudip-PC> <1434529234.2689.69.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434529234.2689.69.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2015 at 01:20:34AM -0700, Joe Perches wrote: > On Wed, 2015-06-17 at 13:45 +0530, Sudip Mukherjee wrote: > > On Tue, Jun 16, 2015 at 10:33:57AM -0700, Joe Perches wrote: > > > On Tue, 2015-06-16 at 19:12 +0530, Sudip Mukherjee wrote: > > > > move vgamode table from the header file to the C file and mark it > > > > as const. > > > > > > The slightly odd indentation could be fixed here too. > > Ok. I am sending v2. But if I am reviewing it I will say > > "you are doing too many things in one patch" :( . > > so i will fix the indention the other patch which is fixing indention. > > You could send a follow-up patch to fix it rather than send > a v3 of everything. v2 already sent and seeing your mail after sending. No problem, everything will be fixed at a time. regards sudip > > cheers, Joe > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Date: Wed, 17 Jun 2015 11:42:50 +0000 Subject: Re: [PATCH 7/8] staging: sm7xxfb: move mode table Message-Id: <20150617113050.GA8337@sudip-PC> List-Id: References: <1434462131-15191-1-git-send-email-sudipm.mukherjee@gmail.com> <1434462131-15191-7-git-send-email-sudipm.mukherjee@gmail.com> <1434476037.2689.1.camel@perches.com> <20150617081522.GB13043@sudip-PC> <1434529234.2689.69.camel@perches.com> In-Reply-To: <1434529234.2689.69.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org On Wed, Jun 17, 2015 at 01:20:34AM -0700, Joe Perches wrote: > On Wed, 2015-06-17 at 13:45 +0530, Sudip Mukherjee wrote: > > On Tue, Jun 16, 2015 at 10:33:57AM -0700, Joe Perches wrote: > > > On Tue, 2015-06-16 at 19:12 +0530, Sudip Mukherjee wrote: > > > > move vgamode table from the header file to the C file and mark it > > > > as const. > > > > > > The slightly odd indentation could be fixed here too. > > Ok. I am sending v2. But if I am reviewing it I will say > > "you are doing too many things in one patch" :( . > > so i will fix the indention the other patch which is fixing indention. > > You could send a follow-up patch to fix it rather than send > a v3 of everything. v2 already sent and seeing your mail after sending. No problem, everything will be fixed at a time. regards sudip > > cheers, Joe >