From: "Michael S. Tsirkin" <mst@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>,
Kevin O'Connor <kevin@koconnor.net>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 7/7] hw/pci-bridge: format SeaBIOS-compliant OFW device node for PXB
Date: Wed, 17 Jun 2015 17:05:44 +0200 [thread overview]
Message-ID: <20150617150544.GA26500@redhat.com> (raw)
In-Reply-To: <55818819.3010107@redhat.com>
On Wed, Jun 17, 2015 at 04:45:45PM +0200, Laszlo Ersek wrote:
> On 06/17/15 16:18, Kevin O'Connor wrote:
> > On Wed, Jun 17, 2015 at 03:57:36PM +0200, Michael S. Tsirkin wrote:
> >> On Wed, Jun 17, 2015 at 02:45:05PM +0200, Laszlo Ersek wrote:
> >>> SeaBIOS expects OpenFirmware device paths in the "bootorder" fw_cfg file
> >>> to follow the pattern
> >>>
> >>> /pci-root@N/pci@i0cf8/...
> >>
> >> It's kind of crazy, isn't it?
> >> /pci@i0cf8/pci-root@N would make some sense: access rootN through cf8.
> >>
> >> But if bios needs to keep this for compatibility, maybe
> >> we have too, to. Kevin?
> >
> > I have no issue with changing the string in SeaBIOS. In a previous
> > email we discussed "/pci@i0cf8/pci-root@%x/" as well as
> > "/pci@i0cf8,%x/", but anything that makes sense is fine with me.
>
> It is not fine with me.
>
> Every time there is another idea about this format, I get to update and
> repost the OVMF series (consisting of 24 patches), which of course
> nobody on qemu-devel@ and seabios@ cares about, while it is actually the
> *only* thing that matters to me. Plus, this patch appeared in v4 and has
> been reposted without changes twice.
>
> Honestly, the format looks outright retarded to me, but I didn't
> complain, because adopting it (and not patching SeaBIOS at all) was the
> most direct way forward. (Most direct in the sense that we're now at
> v6.) I will *not* repeat the entire discussion about the format, and I
> won't revisit that outcome. I have spent several nights and weekend days
> on implementing SeaBIOS-compatible code in qemu and OVMF, and I won't go
> back on that work.
>
> Similarly, the patch "hw/pci-bridge: create interrupt-less, hotplug-less
> bridge for PXB" has been present in the QEMU series without functional
> changes since v2. I've been aware that it doesn't meet Michael's taste
> (that fact was documented in v2), but I'm appalled that it has taken 4
> reposts (v3 to v6) to arrive at specifics. Not only did that cause me to
> miss 4 opportunities to post an ultimately acceptable patch, it also
> wasted the reviews of Marcel and Markus, plus my work to address
> Markus's review.
>
> I've been going out of my way to be cooperative, responsive, and just do
> whatever I've been told, minimize the impact, etc. As I said, I'm
> willing to post a v7 for the SHPC-less pci-bridge device model, but no
> more versions, and no other changes.
>
> Thanks
> Laszlo
Sorry you feel bad. Looks like the patches are pretty close to being
ready.
If you just address the comments about the bridge then I can merge
patches 1-5 directly.
We do need to agree about the correct paths however, this is host/guest
interface which we have to maintain forever, and it's important to get
it right. I kept hoping we can come up with something saner than
the sequence # but oh well. Do you disagree with the statement
that seabios path is currently incorrect? Kevin seems to agree.
--
MST
next prev parent reply other threads:[~2015-06-17 15:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 12:44 [Qemu-devel] [PATCH v6 0/7] PXB changes Laszlo Ersek
2015-06-17 12:44 ` [Qemu-devel] [PATCH v6 1/7] migration: introduce VMSTATE_BUFFER_UNSAFE_INFO_TEST() Laszlo Ersek
2015-06-17 12:45 ` [Qemu-devel] [PATCH v6 2/7] hw/pci-bridge: expose _test parameter in SHPC_VMSTATE() Laszlo Ersek
2015-06-17 12:45 ` [Qemu-devel] [PATCH v6 3/7] hw/pci-bridge: introduce "hotplug" property Laszlo Ersek
2015-06-17 13:42 ` Michael S. Tsirkin
2015-06-17 13:55 ` Laszlo Ersek
2015-06-17 14:02 ` Michael S. Tsirkin
2015-06-17 14:15 ` Laszlo Ersek
2015-06-17 19:54 ` Marcel Apfelbaum
2015-06-18 13:47 ` Paolo Bonzini
2015-06-18 14:44 ` Michael S. Tsirkin
2015-06-17 12:45 ` [Qemu-devel] [PATCH v6 4/7] hw/pci-bridge: disable hotplug in PXB Laszlo Ersek
2015-06-17 13:45 ` Michael S. Tsirkin
2015-06-17 19:52 ` Marcel Apfelbaum
2015-06-17 12:45 ` [Qemu-devel] [PATCH v6 5/7] hw/core: rebase sysbus_get_fw_dev_path() to g_strdup_printf() Laszlo Ersek
2015-06-17 13:46 ` Michael S. Tsirkin
2015-06-17 13:56 ` Laszlo Ersek
2015-06-17 12:45 ` [Qemu-devel] [PATCH v6 6/7] hw/core: explicit OFW unit address callback for SysBusDeviceClass Laszlo Ersek
2015-06-17 12:45 ` [Qemu-devel] [PATCH v6 7/7] hw/pci-bridge: format SeaBIOS-compliant OFW device node for PXB Laszlo Ersek
2015-06-17 13:57 ` Michael S. Tsirkin
2015-06-17 14:00 ` Laszlo Ersek
2015-06-17 14:03 ` Michael S. Tsirkin
2015-06-17 14:18 ` Kevin O'Connor
2015-06-17 14:45 ` Laszlo Ersek
2015-06-17 15:05 ` Michael S. Tsirkin [this message]
2015-06-17 18:16 ` Laszlo Ersek
2015-06-17 18:54 ` Michael S. Tsirkin
2015-06-17 19:15 ` Laszlo Ersek
2015-06-17 19:28 ` Kevin O'Connor
2015-06-17 19:32 ` Michael S. Tsirkin
2015-06-17 19:44 ` Laszlo Ersek
2015-06-17 21:50 ` Michael S. Tsirkin
2015-06-18 13:22 ` Laszlo Ersek
2015-06-18 13:40 ` Michael S. Tsirkin
2015-06-18 15:42 ` Laszlo Ersek
2015-06-17 19:09 ` Kevin O'Connor
2015-06-17 19:21 ` Michael S. Tsirkin
2015-06-17 19:35 ` Laszlo Ersek
2015-06-17 21:49 ` Michael S. Tsirkin
2015-06-18 13:18 ` Laszlo Ersek
2015-06-17 19:38 ` Kevin O'Connor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617150544.GA26500@redhat.com \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=kevin@koconnor.net \
--cc=lersek@redhat.com \
--cc=marcel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.