From: Pavel Machek <pavel@ucw.cz>
To: Paul Bolle <pebolle@tiscali.nl>,
imre.deak@intel.com, ville.syrjala@linux.intel.com,
daniel.vetter@ffwll.ch,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linus <linus_torvalds@foxmail.com>, lenb <lenb@kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
linux-pm <linux-pm@vger.kernel.org>
Subject: da2bc1b9db3351addd293e5b82757efe1f77ed1d breaks hibernation was Re: 4.1-rc7, thinkpad X60: platform mode hibernation does very wrongthing
Date: Wed, 17 Jun 2015 17:18:00 +0200 [thread overview]
Message-ID: <20150617151800.GA12312@amd> (raw)
In-Reply-To: <1434549754.2400.5.camel@x220>
Hi!
> And this all reminded me of https://lkml.org/lkml/2015/3/18/133 . So I
> think that's another system not covered by commit ab3be73fa7b4
> ("drm/i915: gen4: work around hang during hibernation").
Yes, another system broken by
commit da2bc1b9db3351addd293e5b82757efe1f77ed1d
Author: Imre Deak <imre.deak@intel.com>
Date: Thu Oct 23 19:23:26 2014 +0300
drm/i915: add poweroff_late handler
The suspend_late handler saves some registers and powers off the
device,
so it doesn't have a big overhead. Calling it at S4
poweroff_late time
makes the power off handling identical to the S3 suspend and
S4 freeze
handling, so do this for consistency.
And no, adding another system to the "blacklist" is a not good idea,
because we know there are other broken systems out there. Can we
revert da2bc1b9db3351addd293e5b82757efe1f77ed1d, please? Consistency
is nice, but not having regressions is even nicer.
Pavel
PS: Now I have real Linus and fake Linus on the Cc list. Or maybe two
real Linuses, its hard to tell.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-06-17 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 12:13 4.1-rc7, thinkpad X60: platform mode hibernation does very wrong thing Pavel Machek
[not found] ` <tencent_191436EF7F89540B416DB7A5@qq.com>
2015-06-17 12:48 ` 4.1-rc7, thinkpad X60: platform mode hibernation does very wrongthing Rafael J. Wysocki
2015-06-17 12:33 ` Pavel Machek
2015-06-17 13:14 ` Rafael J. Wysocki
2015-06-17 13:16 ` Pavel Machek
2015-06-17 14:02 ` Paul Bolle
2015-06-17 15:18 ` Pavel Machek [this message]
2015-06-30 9:44 ` da2bc1b9db3351addd293e5b82757efe1f77ed1d breaks hibernation was " Pavel Machek
2015-06-30 15:29 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617151800.GA12312@amd \
--to=pavel@ucw.cz \
--cc=daniel.vetter@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=lenb@kernel.org \
--cc=linus_torvalds@foxmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=rjw@rjwysocki.net \
--cc=torvalds@linux-foundation.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.