From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756776AbbFQP6l (ORCPT ); Wed, 17 Jun 2015 11:58:41 -0400 Received: from down.free-electrons.com ([37.187.137.238]:38280 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754990AbbFQP6c (ORCPT ); Wed, 17 Jun 2015 11:58:32 -0400 Date: Wed, 17 Jun 2015 17:58:28 +0200 From: Boris Brezillon To: Boris Brezillon Cc: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, Arnaud Ebalard , Tawfik Bayouk , Lior Amsalem , Nadav Haklai , Eran Ben-Avi , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , Imre Kaloz Subject: Re: [PATCH v7 05/14] crypto: marvell/CESA: add TDMA support Message-ID: <20150617175828.2a83cda6@bbrezillon> In-Reply-To: <20150617173402.7946bbb0@bbrezillon> References: <20150617122533.GA13185@gondor.apana.org.au> <1434547922-10363-1-git-send-email-boris.brezillon@free-electrons.com> <20150617150808.GA14915@gondor.apana.org.au> <20150617173402.7946bbb0@bbrezillon> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Jun 2015 17:34:02 +0200 Boris Brezillon wrote: > On Wed, 17 Jun 2015 23:08:08 +0800 > Herbert Xu wrote: > > > On Wed, Jun 17, 2015 at 03:32:02PM +0200, Boris Brezillon wrote: > > > > > > Hi Herbert, > > > > > > I send you this patch alone so that you can verify I'm now properly > > > manipulating the SG list. Once I have your confirmation I'll send > > > the whole series again and annoy all the people in Cc one more time > > > ;-). > > > > Thanks. The only problem that I can see is the fact you're not > > checking for req->src == req->dst. If they're equal then you must > > not map it twice. Instead it should be mapped as DMA_BIDIRECTIONAL. > > I can check for that too, but note that it doesn't prevent one from > providing different scatterlist structures pointing to the same memory > region. Actually, I don't know if it's a problem or not, so if it's not, please ignore my comment. > This being said, checking for req->src == req->dst should fix the case > where dst and src are pointing to the same scatterlist, which is a good > start. Here is an incremental patch [1], please let me know if something else is missing. Thanks, Boris [1]http://code.bulix.org/x8mz8x-88568 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v7 05/14] crypto: marvell/CESA: add TDMA support Date: Wed, 17 Jun 2015 17:58:28 +0200 Message-ID: <20150617175828.2a83cda6@bbrezillon> References: <20150617122533.GA13185@gondor.apana.org.au> <1434547922-10363-1-git-send-email-boris.brezillon@free-electrons.com> <20150617150808.GA14915@gondor.apana.org.au> <20150617173402.7946bbb0@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, Arnaud Ebalard , Tawfik Bayouk , Lior Amsalem , Nadav Haklai , Eran Ben-Avi , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , Imre Kaloz Return-path: Received: from down.free-electrons.com ([37.187.137.238]:38280 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754990AbbFQP6c (ORCPT ); Wed, 17 Jun 2015 11:58:32 -0400 In-Reply-To: <20150617173402.7946bbb0@bbrezillon> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, 17 Jun 2015 17:34:02 +0200 Boris Brezillon wrote: > On Wed, 17 Jun 2015 23:08:08 +0800 > Herbert Xu wrote: > > > On Wed, Jun 17, 2015 at 03:32:02PM +0200, Boris Brezillon wrote: > > > > > > Hi Herbert, > > > > > > I send you this patch alone so that you can verify I'm now properly > > > manipulating the SG list. Once I have your confirmation I'll send > > > the whole series again and annoy all the people in Cc one more time > > > ;-). > > > > Thanks. The only problem that I can see is the fact you're not > > checking for req->src == req->dst. If they're equal then you must > > not map it twice. Instead it should be mapped as DMA_BIDIRECTIONAL. > > I can check for that too, but note that it doesn't prevent one from > providing different scatterlist structures pointing to the same memory > region. Actually, I don't know if it's a problem or not, so if it's not, please ignore my comment. > This being said, checking for req->src == req->dst should fix the case > where dst and src are pointing to the same scatterlist, which is a good > start. Here is an incremental patch [1], please let me know if something else is missing. Thanks, Boris [1]http://code.bulix.org/x8mz8x-88568 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v7 05/14] crypto: marvell/CESA: add TDMA support Date: Wed, 17 Jun 2015 17:58:28 +0200 Message-ID: <20150617175828.2a83cda6@bbrezillon> References: <20150617122533.GA13185@gondor.apana.org.au> <1434547922-10363-1-git-send-email-boris.brezillon@free-electrons.com> <20150617150808.GA14915@gondor.apana.org.au> <20150617173402.7946bbb0@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150617173402.7946bbb0@bbrezillon> Sender: linux-crypto-owner@vger.kernel.org To: Boris Brezillon Cc: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, Arnaud Ebalard , Tawfik Bayouk , Lior Amsalem , Nadav Haklai , Eran Ben-Avi , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , Imre Kaloz List-Id: devicetree@vger.kernel.org On Wed, 17 Jun 2015 17:34:02 +0200 Boris Brezillon wrote: > On Wed, 17 Jun 2015 23:08:08 +0800 > Herbert Xu wrote: > > > On Wed, Jun 17, 2015 at 03:32:02PM +0200, Boris Brezillon wrote: > > > > > > Hi Herbert, > > > > > > I send you this patch alone so that you can verify I'm now properly > > > manipulating the SG list. Once I have your confirmation I'll send > > > the whole series again and annoy all the people in Cc one more time > > > ;-). > > > > Thanks. The only problem that I can see is the fact you're not > > checking for req->src == req->dst. If they're equal then you must > > not map it twice. Instead it should be mapped as DMA_BIDIRECTIONAL. > > I can check for that too, but note that it doesn't prevent one from > providing different scatterlist structures pointing to the same memory > region. Actually, I don't know if it's a problem or not, so if it's not, please ignore my comment. > This being said, checking for req->src == req->dst should fix the case > where dst and src are pointing to the same scatterlist, which is a good > start. Here is an incremental patch [1], please let me know if something else is missing. Thanks, Boris [1]http://code.bulix.org/x8mz8x-88568 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Wed, 17 Jun 2015 17:58:28 +0200 Subject: [PATCH v7 05/14] crypto: marvell/CESA: add TDMA support In-Reply-To: <20150617173402.7946bbb0@bbrezillon> References: <20150617122533.GA13185@gondor.apana.org.au> <1434547922-10363-1-git-send-email-boris.brezillon@free-electrons.com> <20150617150808.GA14915@gondor.apana.org.au> <20150617173402.7946bbb0@bbrezillon> Message-ID: <20150617175828.2a83cda6@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 17 Jun 2015 17:34:02 +0200 Boris Brezillon wrote: > On Wed, 17 Jun 2015 23:08:08 +0800 > Herbert Xu wrote: > > > On Wed, Jun 17, 2015 at 03:32:02PM +0200, Boris Brezillon wrote: > > > > > > Hi Herbert, > > > > > > I send you this patch alone so that you can verify I'm now properly > > > manipulating the SG list. Once I have your confirmation I'll send > > > the whole series again and annoy all the people in Cc one more time > > > ;-). > > > > Thanks. The only problem that I can see is the fact you're not > > checking for req->src == req->dst. If they're equal then you must > > not map it twice. Instead it should be mapped as DMA_BIDIRECTIONAL. > > I can check for that too, but note that it doesn't prevent one from > providing different scatterlist structures pointing to the same memory > region. Actually, I don't know if it's a problem or not, so if it's not, please ignore my comment. > This being said, checking for req->src == req->dst should fix the case > where dst and src are pointing to the same scatterlist, which is a good > start. Here is an incremental patch [1], please let me know if something else is missing. Thanks, Boris [1]http://code.bulix.org/x8mz8x-88568 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com