From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756856AbbFQS3B (ORCPT ); Wed, 17 Jun 2015 14:29:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51364 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753033AbbFQS2w (ORCPT ); Wed, 17 Jun 2015 14:28:52 -0400 Date: Wed, 17 Jun 2015 20:28:44 +0200 From: Jiri Olsa To: Wang Nan Cc: acme@kernel.org, namhyung@kernel.org, masami.hiramatsu.pt@hitachi.com, a.p.zijlstra@chello.nl, mingo@redhat.com, jolsa@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com, lizefan@huawei.com, hekuang@huawei.com Subject: Re: [PATCH] perf tools: Move libtraceevent dynamic list to separated LDFLAGS variable Message-ID: <20150617182844.GB18600@krava> References: <1434552389-89144-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434552389-89144-1-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2015 at 02:46:29PM +0000, Wang Nan wrote: > Commit e3d09ec8126fe2c9a3ade661e2126e215ca27a80 ("tools lib traceevent: > Export dynamic symbols used by traceevent plugins") adds libtraceevent > dynamic list directly into LDFLAGS, which makes all targets depend on > that list through LDFLAGS. This is not good since some of targets like > libgtk.so doesn't use plugin at all, but require the existance of that > list because of linker options. > > This patch isolates the -Xlink option into LIBTRACEEVENT_DYNAMIC_LIST_LDFLAGS, > makes only perf and perf.so use it. > > Signed-off-by: Wang Nan Acked-by: Jiri Olsa thanks, jirka