From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Iui-0000Lu-IN for qemu-devel@nongnu.org; Wed, 17 Jun 2015 15:22:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5Iuh-0008CB-MU for qemu-devel@nongnu.org; Wed, 17 Jun 2015 15:22:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Iuh-0008Bl-C2 for qemu-devel@nongnu.org; Wed, 17 Jun 2015 15:22:19 -0400 Date: Wed, 17 Jun 2015 21:22:14 +0200 From: "Michael S. Tsirkin" Message-ID: <20150617212142-mutt-send-email-mst@redhat.com> References: <20150617160826-mutt-send-email-mst@redhat.com> <558180A0.8040708@redhat.com> <20150617161716-mutt-send-email-mst@redhat.com> <558183C1.3010402@redhat.com> <20150617162836-mutt-send-email-mst@redhat.com> <55819D8F.3000003@redhat.com> <20150617182322-mutt-send-email-mst@redhat.com> <5581A4E8.8080505@redhat.com> <20150617184357.GA7080@redhat.com> <5581C76C.70609@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5581C76C.70609@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Markus Armbruster , qemu-devel@nongnu.org, Don Slutz , Luiz Capitulino , Anthony Liguori , Andreas =?iso-8859-1?Q?F=E4rber?= , Richard Henderson On Wed, Jun 17, 2015 at 09:15:56PM +0200, Paolo Bonzini wrote: > > > On 17/06/2015 20:43, Michael S. Tsirkin wrote: > > It seems pretty obvious: > > > > + vmport_rpc = isa_try_create(isa_bus, "vmport_rpc"); > > + if (vmport_rpc) { > > + qdev_init_nofail(DEVICE(vmport_rpc)); > > + } > > > > > > Don't do this. Let user specify the device using -device vmport_rpc. > > Then all issues just go away. I don't see any reason not to do it like > > this - we should have done the same for other vmport things. > > Does it make sense to have an ISA device that has no ports or MMIO > regions? It's a bit of hack modeling-wise, but sure it works. > > Paolo I didn't write this code :) -- MST