From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/skl: Buffer translation improvements
Date: Thu, 18 Jun 2015 11:10:13 +0100 [thread overview]
Message-ID: <20150618101013.GE24012@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20150618095033.GH14570@boom>
On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote:
> +static const struct ddi_buf_trans *skl_get_buf_trans_dp(struct drm_device *dev,
struct drm_i915_private not struct drm_device!
> + int *n_entries)
> +{
> + struct drm_i915_private *dev_priv = dev->dev_private;
> + const struct ddi_buf_trans *ddi_translations;
> + static int is_095v = -1;
> +
> + if (is_095v == -1) {
> + u32 spr1 = I915_READ(UAIMI_SPR1);
> + is_095v = spr1 & SKL_VCCIO_MASK;
> + }
> +
> + if (IS_SKL_ULX(dev) && !is_095v) {
> + ddi_translations = skl_y_085v_ddi_translations_dp;
> + *n_entries = ARRAY_SIZE(skl_y_085v_ddi_translations_dp);
> + } else if (IS_SKL_ULT(dev)) {
> + ddi_translations = skl_u_ddi_translations_dp;
> + *n_entries = ARRAY_SIZE(skl_u_ddi_translations_dp);
> + } else {
> + ddi_translations = skl_ddi_translations_dp;
> + *n_entries = ARRAY_SIZE(skl_ddi_translations_dp);
> + }
These are static routing, but called fairly often. (Often enough that
you care to only read the reigster once.) Any reason not to preserve
these routing tables in dev_priv or, slightly more preferrable, intel_dp?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-18 10:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 9:50 [PATCH] drm/i915/skl: Buffer translation improvements David Weinehall
2015-06-18 10:10 ` Chris Wilson [this message]
2015-06-18 10:47 ` David Weinehall
2015-06-18 10:59 ` Chris Wilson
2015-06-23 10:28 ` David Weinehall
2015-06-25 8:09 ` David Weinehall
2015-06-18 15:05 ` Daniel Vetter
2015-06-23 10:47 ` David Weinehall
2015-06-23 11:12 ` David Weinehall
2015-06-23 12:07 ` Daniel Vetter
2015-06-24 4:47 ` Jindal, Sonika
2015-06-25 10:18 ` David Weinehall
2015-06-25 8:11 ` [PATCH v2] " David Weinehall
2015-06-29 10:35 ` Antti Koskipää
2015-06-29 16:12 ` Daniel Vetter
2015-06-30 10:27 ` David Weinehall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618101013.GE24012@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.