From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38327)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <qemu-devel@PaulSD.com>) id 1Z5ZOk-0003Ud-Au
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 08:58:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <qemu-devel@PaulSD.com>) id 1Z5ZOg-0003Oj-BE
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 08:58:26 -0400
Received: from lepton.topquark.net ([168.235.66.66]:37211
	helo=Mail2.TopQuark.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <qemu-devel@PaulSD.com>) id 1Z5ZOg-0003Od-7S
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 08:58:22 -0400
Date: Thu, 18 Jun 2015 08:58:19 -0400
From: Paul Donohue <qemu-devel@PaulSD.com>
Message-ID: <20150618125819.GA7886@TopQuark.net>
References: <20150612140845.GD2749@TopQuark.net> <55817D66.2090303@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55817D66.2090303@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-timer: Call clock reset notifiers
 on forward jumps
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, Jun 17, 2015 at 04:00:06PM +0200, Paolo Bonzini wrote:
> On 12/06/2015 16:08, Paul Donohue wrote:
> > +static inline int64_t get_max_clock_jump(void)
> > +{
> > +    // This should be small enough to prevent excessive interrupts from being
> > +    // generated by the RTC on clock jumps, but large enough to avoid frequent
> > +    // unnecessary resets in idle VMs.
> This is not how comments are layed out in QEMU...
Oops.  Sorry, I'm not sure how I missed that.  Force of habit from 
other projects, I guess...

> > +    return 60 * get_ticks_per_sec();
> > +}
> > +
> >  /*
> >  *   * Low level clock functions
> >  *     */
> ... and it also looks like your editor has mangled this patch.
Ugh, yes.  I do remember noticing that, and I thought I fixed it, but 
apparently not.

I will correct and send an updated patch.