From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753827AbbFROCl (ORCPT ); Thu, 18 Jun 2015 10:02:41 -0400 Received: from down.free-electrons.com ([37.187.137.238]:38545 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751529AbbFROCe (ORCPT ); Thu, 18 Jun 2015 10:02:34 -0400 Date: Thu, 18 Jun 2015 16:02:32 +0200 From: Alexandre Belloni To: Nicolas Ferre Cc: Maxime Ripard , Ludovic Desroches , jic23@kernel.org, linux-arm-kernel@lists.infradead.org, Josh Wu , leupold@rsi-elektrotechnik.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: adc: at91_adc: allow to use full range of startup time Message-ID: <20150618140232.GE27492@piout.net> References: <1434558096-10619-1-git-send-email-nicolas.ferre@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434558096-10619-1-git-send-email-nicolas.ferre@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/06/2015 at 18:21:36 +0200, Nicolas Ferre wrote : > From: Jan Leupold > > The DT-Property "atmel,adc-startup-time" is stored in an u8 for a microsecond > value. When trying to increase the value of STARTUP in Register AT91_ADC_MR > some higher values can't be reached. > > Change the type in function parameter and private structure field from u8 to > u32. > > Signed-off-by: Jan Leupold > [nicolas.ferre@atmel.com: change commit message, increase u16 to u32 for startup time] > Signed-off-by: Nicolas Ferre Acked-by: Alexandre Belloni > --- > drivers/iio/adc/at91_adc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 8a0eb4a04fb5..7b40925dd4ff 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -182,7 +182,7 @@ struct at91_adc_caps { > u8 ts_pen_detect_sensitivity; > > /* startup time calculate function */ > - u32 (*calc_startup_ticks)(u8 startup_time, u32 adc_clk_khz); > + u32 (*calc_startup_ticks)(u32 startup_time, u32 adc_clk_khz); > > u8 num_channels; > struct at91_adc_reg_desc registers; > @@ -201,7 +201,7 @@ struct at91_adc_state { > u8 num_channels; > void __iomem *reg_base; > struct at91_adc_reg_desc *registers; > - u8 startup_time; > + u32 startup_time; > u8 sample_hold_time; > bool sleep_mode; > struct iio_trigger **trig; > @@ -779,7 +779,7 @@ ret: > return ret; > } > > -static u32 calc_startup_ticks_9260(u8 startup_time, u32 adc_clk_khz) > +static u32 calc_startup_ticks_9260(u32 startup_time, u32 adc_clk_khz) > { > /* > * Number of ticks needed to cover the startup time of the ADC > @@ -790,7 +790,7 @@ static u32 calc_startup_ticks_9260(u8 startup_time, u32 adc_clk_khz) > return round_up((startup_time * adc_clk_khz / 1000) - 1, 8) / 8; > } > > -static u32 calc_startup_ticks_9x5(u8 startup_time, u32 adc_clk_khz) > +static u32 calc_startup_ticks_9x5(u32 startup_time, u32 adc_clk_khz) > { > /* > * For sama5d3x and at91sam9x5, the formula changes to: > -- > 2.1.3 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Thu, 18 Jun 2015 16:02:32 +0200 Subject: [PATCH] iio: adc: at91_adc: allow to use full range of startup time In-Reply-To: <1434558096-10619-1-git-send-email-nicolas.ferre@atmel.com> References: <1434558096-10619-1-git-send-email-nicolas.ferre@atmel.com> Message-ID: <20150618140232.GE27492@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 17/06/2015 at 18:21:36 +0200, Nicolas Ferre wrote : > From: Jan Leupold > > The DT-Property "atmel,adc-startup-time" is stored in an u8 for a microsecond > value. When trying to increase the value of STARTUP in Register AT91_ADC_MR > some higher values can't be reached. > > Change the type in function parameter and private structure field from u8 to > u32. > > Signed-off-by: Jan Leupold > [nicolas.ferre at atmel.com: change commit message, increase u16 to u32 for startup time] > Signed-off-by: Nicolas Ferre Acked-by: Alexandre Belloni > --- > drivers/iio/adc/at91_adc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 8a0eb4a04fb5..7b40925dd4ff 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -182,7 +182,7 @@ struct at91_adc_caps { > u8 ts_pen_detect_sensitivity; > > /* startup time calculate function */ > - u32 (*calc_startup_ticks)(u8 startup_time, u32 adc_clk_khz); > + u32 (*calc_startup_ticks)(u32 startup_time, u32 adc_clk_khz); > > u8 num_channels; > struct at91_adc_reg_desc registers; > @@ -201,7 +201,7 @@ struct at91_adc_state { > u8 num_channels; > void __iomem *reg_base; > struct at91_adc_reg_desc *registers; > - u8 startup_time; > + u32 startup_time; > u8 sample_hold_time; > bool sleep_mode; > struct iio_trigger **trig; > @@ -779,7 +779,7 @@ ret: > return ret; > } > > -static u32 calc_startup_ticks_9260(u8 startup_time, u32 adc_clk_khz) > +static u32 calc_startup_ticks_9260(u32 startup_time, u32 adc_clk_khz) > { > /* > * Number of ticks needed to cover the startup time of the ADC > @@ -790,7 +790,7 @@ static u32 calc_startup_ticks_9260(u8 startup_time, u32 adc_clk_khz) > return round_up((startup_time * adc_clk_khz / 1000) - 1, 8) / 8; > } > > -static u32 calc_startup_ticks_9x5(u8 startup_time, u32 adc_clk_khz) > +static u32 calc_startup_ticks_9x5(u32 startup_time, u32 adc_clk_khz) > { > /* > * For sama5d3x and at91sam9x5, the formula changes to: > -- > 2.1.3 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com