From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44741)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Z5b39-0003NE-Os
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 10:44:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Z5b36-0002fD-3i
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 10:44:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58308)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Z5b35-0002eq-Uq
	for qemu-devel@nongnu.org; Thu, 18 Jun 2015 10:44:12 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id 5AC002DC43A
	for <qemu-devel@nongnu.org>; Thu, 18 Jun 2015 14:44:11 +0000 (UTC)
Date: Thu, 18 Jun 2015 16:44:08 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150618144408.GA20165@redhat.com>
References: <1434545105-5811-1-git-send-email-lersek@redhat.com>
	<1434545105-5811-4-git-send-email-lersek@redhat.com>
	<20150617154135-mutt-send-email-mst@redhat.com>
	<55817C54.1000201@redhat.com>
	<20150617155751-mutt-send-email-mst@redhat.com>
	<5582CBFD.8090604@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5582CBFD.8090604@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 3/7] hw/pci-bridge: introduce "hotplug"
	property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>, Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org

On Thu, Jun 18, 2015 at 03:47:41PM +0200, Paolo Bonzini wrote:
> 
> 
> On 17/06/2015 16:02, Michael S. Tsirkin wrote:
> > > Are you okay with the flag's name, PCI_BRIDGE_DEV_F_HOTPLUG? If not,
> > > what would be your preference?
> > 
> > PCI_BRIDGE_DEV_F_SHPC_REQ
> 
> Do not abbrev unless necessary. :)  What about PCI_BRIDGE_DEV_F_HAS_SHPC
> or even just PCI_BRIDGE_DEV_F_SHPC?
> 
> Paolo

The point of _REQ is that it's requested by user.
This avoids confusion with two other flags,
one checking whether a feature is present, another
whether it's enabled.

> > Also add macro for "shpc" property string to avoid duplication.
> > Also clear msi explicitly - no need for that to depend on shpc.
> >