From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754342AbbFRPVK (ORCPT ); Thu, 18 Jun 2015 11:21:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:42330 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752487AbbFRPVH (ORCPT ); Thu, 18 Jun 2015 11:21:07 -0400 Date: Thu, 18 Jun 2015 17:21:05 +0200 From: Alexandre Belloni To: Nicolas Ferre Cc: Jean-Christophe PLAGNIOL-VILLARD , Boris BREZILLON , Ludovic Desroches , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ARM: at91/soc: add basic support for new sama5d2 SoC Message-ID: <20150618152105.GK27492@piout.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 18/06/2015 at 15:18:28 +0200, Nicolas Ferre wrote : > diff --git a/Documentation/arm/Atmel/README b/Documentation/arm/Atmel/README > index c53a19b4aab2..6650a8ffaa64 100644 > --- a/Documentation/arm/Atmel/README > +++ b/Documentation/arm/Atmel/README > @@ -90,6 +90,12 @@ the Atmel website: http://www.atmel.com. > + Datasheet > http://www.atmel.com/Images/Atmel-11238-32-bit-Cortex-A5-Microcontroller-SAMA5D4_Datasheet.pdf > > + * ARM Cortex-A5 + NEON based SoCs > + - sama5d2 family > + - sama5d27 > + + Datasheet > + Coming soon Shouldn't that go directly before or after the sama5d4 family ? > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index f1b157971366..140228d033c2 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -141,6 +141,12 @@ choice > depends on ARCH_AT91 > depends on SOC_SAMA5 > > + config AT91_DEBUG_LL_DBGU3 > + bool "Kernel low-level debugging on sama5d2" > + select DEBUG_AT91_UART > + depends on ARCH_AT91 > + depends on SOC_SAMA5 > + I think that at some point we'll have to kill those AT91_DEBUG_LL_* which are actually board specific and not soc specific. I already have a patch for that that I need to rebase. > diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig > index 43ec794d1057..e53780a28605 100644 > --- a/arch/arm/mach-at91/Kconfig > +++ b/arch/arm/mach-at91/Kconfig > @@ -8,6 +8,18 @@ menuconfig ARCH_AT91 > select SOC_BUS > > if ARCH_AT91 > +config SOC_SAMA5D2 > + bool "SAMA5D2 family" if ARCH_MULTI_V7 > + select SOC_SAMA5 > + select CACHE_L2X0 > + select HAVE_FB_ATMEL > + select HAVE_AT91_UTMI > + select HAVE_AT91_USB_CLK > + select HAVE_AT91_H32MX > + select HAVE_AT91_GENERATED Seeing that, I think HAVE_AT91_GENERATED should include CLK somewhere in the name as this is only related to clocks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Thu, 18 Jun 2015 17:21:05 +0200 Subject: [PATCH 1/3] ARM: at91/soc: add basic support for new sama5d2 SoC In-Reply-To: References: Message-ID: <20150618152105.GK27492@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 18/06/2015 at 15:18:28 +0200, Nicolas Ferre wrote : > diff --git a/Documentation/arm/Atmel/README b/Documentation/arm/Atmel/README > index c53a19b4aab2..6650a8ffaa64 100644 > --- a/Documentation/arm/Atmel/README > +++ b/Documentation/arm/Atmel/README > @@ -90,6 +90,12 @@ the Atmel website: http://www.atmel.com. > + Datasheet > http://www.atmel.com/Images/Atmel-11238-32-bit-Cortex-A5-Microcontroller-SAMA5D4_Datasheet.pdf > > + * ARM Cortex-A5 + NEON based SoCs > + - sama5d2 family > + - sama5d27 > + + Datasheet > + Coming soon Shouldn't that go directly before or after the sama5d4 family ? > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug > index f1b157971366..140228d033c2 100644 > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -141,6 +141,12 @@ choice > depends on ARCH_AT91 > depends on SOC_SAMA5 > > + config AT91_DEBUG_LL_DBGU3 > + bool "Kernel low-level debugging on sama5d2" > + select DEBUG_AT91_UART > + depends on ARCH_AT91 > + depends on SOC_SAMA5 > + I think that at some point we'll have to kill those AT91_DEBUG_LL_* which are actually board specific and not soc specific. I already have a patch for that that I need to rebase. > diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig > index 43ec794d1057..e53780a28605 100644 > --- a/arch/arm/mach-at91/Kconfig > +++ b/arch/arm/mach-at91/Kconfig > @@ -8,6 +8,18 @@ menuconfig ARCH_AT91 > select SOC_BUS > > if ARCH_AT91 > +config SOC_SAMA5D2 > + bool "SAMA5D2 family" if ARCH_MULTI_V7 > + select SOC_SAMA5 > + select CACHE_L2X0 > + select HAVE_FB_ATMEL > + select HAVE_AT91_UTMI > + select HAVE_AT91_USB_CLK > + select HAVE_AT91_H32MX > + select HAVE_AT91_GENERATED Seeing that, I think HAVE_AT91_GENERATED should include CLK somewhere in the name as this is only related to clocks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com