From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756043AbbFRQYf (ORCPT <rfc822;w@1wt.eu>);
	Thu, 18 Jun 2015 12:24:35 -0400
Received: from mail-wg0-f49.google.com ([74.125.82.49]:33274 "EHLO
	mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751791AbbFRQY1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 18 Jun 2015 12:24:27 -0400
Date: Thu, 18 Jun 2015 18:24:22 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>,
        Rik van Riel <riel@redhat.com>, Oleg Nesterov <oleg@redhat.com>,
        Denys Vlasenko <vda.linux@googlemail.com>,
        Borislav Petkov <bp@alien8.de>, Kees Cook <keescook@chromium.org>,
        Brian Gerst <brgerst@gmail.com>
Subject: Re: [RFC/INCOMPLETE 00/13] x86: Rewrite exit-to-userspace code
Message-ID: <20150618162422.GA6989@gmail.com>
References: <cover.1434485184.git.luto@kernel.org>
 <20150617103226.GA30325@gmail.com>
 <CALCETrU2oEiHiqb9gu+ZnDU+zOMk+JqDG2dYFVHsAh5xm2tGtw@mail.gmail.com>
 <20150618101110.GA5100@gmail.com>
 <CALCETrVRF34yFtujk+gOUiiPG53bNu+WQH9MgvOa6pdUejb+Kw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrVRF34yFtujk+gOUiiPG53bNu+WQH9MgvOa6pdUejb+Kw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Andy Lutomirski <luto@amacapital.net> wrote:

> On Thu, Jun 18, 2015 at 3:11 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Andy Lutomirski <luto@amacapital.net> wrote:
> >
> >> > The only low level bits remaining in assembly will be low level hardware ABI
> >> > details: saving registers and restoring registers to the expected format - no
> >> > 'active' code whatsoever.
> >>
> >> I think this is true for syscalls.  Getting the weird special cases (IRET and 
> >> GS fault) for error_entry to work correctly in C could be tricky.
> >
> > Correct, and I double checked the IRET fault path yesterday (fixup_bad_iret), 
> > and it looks like a straightforward exception handler with limited control 
> > flow. It can stay in asm just fine, it seems mostly orthogonal to the rest.
> >
> > I didn't check the GS fault path, but that only affects 32-bit, as we use 
> > SWAPGS on 64-bit, right? In any case, that code too (32-bit RESTORE_REGS) 
> > belongs into the natural 'hardware ABI preparation code' that should stay in 
> > assembly. (Unless I missed some other code that might cause trouble.)
> 
> Look for "gs_change".  To change the gs selector, we do swapgs, then load gs, 
> then swapgs again.  If the gs load fails, then we trigger a special fixup.

Yes, but I don't see the connection to moving the syscall (and IRQ) entry code to 
.c: native_load_gs_index() is a separate API we call from regular kernel code, and 
it has a regular exception fixup entry plus a trap handler special case.

It's fine in entry_64.S, but it would be equally fine in inline asm() as well.

I think it's fine in entry_64.S as long as the error trap code (which refers to 
the change_gs RIP) lives there. But it could live in .c as well, as we can 
generate global symbols within inline asm() too.

Thanks,

	Ingo