From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932152AbbFRQdl (ORCPT ); Thu, 18 Jun 2015 12:33:41 -0400 Received: from vsp-authed01.binero.net ([195.74.38.224]:45719 "EHLO bin-vsp-out-02.atm.binero.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751719AbbFRQde (ORCPT ); Thu, 18 Jun 2015 12:33:34 -0400 X-Halon-ID: c0f5caac-15d7-11e5-bc18-005056917f90 Authorized-sender: peter@zapto.se Date: Thu, 18 Jun 2015 18:33:30 +0200 From: Peter Karlsson To: Joe Perches Cc: greg@kroah.com, marek.belisko@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] staging: ft1000-usb: Fixed some issues with lines over 80 characters Message-ID: <20150618163330.GA27895@laptop> Mail-Followup-To: Joe Perches , greg@kroah.com, marek.belisko@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1434635461-24643-1-git-send-email-peter@zapto.se> <1434635461-24643-2-git-send-email-peter@zapto.se> <1434642666.2689.105.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434642666.2689.105.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015-06-18 08:51, Joe Perches wrote: > On Thu, 2015-06-18 at 15:50 +0200, Peter Karlsson wrote: > > Fix checkpatch warnings about lines over 80 characters. > [] > > diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c > [] > > @@ -414,12 +414,20 @@ static long ft1000_ioctl(struct file *file, unsigned int command, > > unsigned long flags; > > struct IOCTL_GET_VER get_ver_data; > > struct IOCTL_GET_DSP_STAT get_stat_data; > > - u8 ConnectionMsg[] = {0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, 0x93, 0x64, > > - 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x00, 0x00, 0x00, 0x0a, > > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x12, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > - 0x00, 0x00, 0x02, 0x37, 0x00, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00, 0x01, 0x00, 0x01, 0x7f, 0x00, > > - 0x00, 0x01, 0x00, 0x00}; > > + u8 ConnectionMsg[] = { > > + 0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00, > > + 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, > > 7 bytes per line is unusual. > 8 or 10 is more common. You are right. I guess i should redo the patches. Frans Klaver also pointed out that four commits have the same commit message, which is not good. Peter