From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756351AbbFRS22 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 18 Jun 2015 14:28:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53938 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752753AbbFRS2N (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 18 Jun 2015 14:28:13 -0400
Date: Thu, 18 Jun 2015 20:27:03 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Benjamin LaHaise <bcrl@kvack.org>, linux-aio@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] aio: make aio_ring->dead boolean
Message-ID: <20150618182703.GA11685@redhat.com>
References: <20150618175209.GA10060@redhat.com> <x49oakclws8.fsf@segfault.boston.devel.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <x49oakclws8.fsf@segfault.boston.devel.redhat.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/18, Jeff Moyer wrote:
>
> Oleg Nesterov <oleg@redhat.com> writes:
> > @@ -765,7 +765,7 @@ static struct kioctx *ioctx_alloc(unsigned nr_events)
> >  err_cleanup:
> >  	aio_nr_sub(ctx->max_reqs);
> >  err_ctx:
> > -	atomic_set(&ctx->dead, 1);
> > +	ctx->dead = true; /* unneeded */
>
> I was hoping you'd remove this line entirely.

Ah. I didn't understand you wamt me to do this... OK, please see v4.

Oleg.