From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5fOQ-0006cW-5J for qemu-devel@nongnu.org; Thu, 18 Jun 2015 15:22:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5fOL-0001uR-5R for qemu-devel@nongnu.org; Thu, 18 Jun 2015 15:22:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5fOK-0001uK-Vx for qemu-devel@nongnu.org; Thu, 18 Jun 2015 15:22:25 -0400 Date: Thu, 18 Jun 2015 16:22:20 -0300 From: Eduardo Habkost Message-ID: <20150618192220.GG3874@thinpad.lan.raisama.net> References: <1434648295-30584-1-git-send-email-crosthwaite.peter@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434648295-30584-1-git-send-email-crosthwaite.peter@gmail.com> Subject: Re: [Qemu-devel] [PATCH v3 0/8] More core code ENV_GET_CPU removals List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Peter Crosthwaite , rth@twiddle.net, qemu-devel@nongnu.org, aurelien@aurel32.net, afaerber@suse.de On Thu, Jun 18, 2015 at 10:24:47AM -0700, Peter Crosthwaite wrote: > Hi All, > > I'm moving towards the goal of having no core code usages of ENV_GET_CPU. > This has two advantages: > > 1: It means we are closer to common-obj'ing core code like exec.c, cpus.c > and friends. > 2: Multi arch is easier if ENV_GET_CPU() stays arch specific. It means I > don't need those patches where I reorder the env within the arch specific > CPUState. This allows continuing placement of arch specifics before the > env in the CPU container (which has TCG perf advantages). > > Due to point 1, I'm sending this ahead as I think it has standalone value, > rather than send as part of multi-arch. Series doesn't apply cleanly on top of latest qemu.git (commit 8ffe756d), due to a small conflict on patch 1/8 (on target-arm/cpu.c). What's the commit ID you used as base for the series? Probably there's no need to resend, though, as "git am -3" seems to handle the conflict properly. -- Eduardo