From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932117AbbFSIOs (ORCPT ); Fri, 19 Jun 2015 04:14:48 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:55884 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751851AbbFSIOg (ORCPT ); Fri, 19 Jun 2015 04:14:36 -0400 Date: Fri, 19 Jun 2015 09:14:33 +0100 From: Charles Keepax To: cw00.choi@samsung.com Cc: Lee Jones , "myungjoo.ham@samsung.com" , Samuel Ortiz , devicetree , linux-kernel , patches@opensource.wolfsonmicro.com Subject: Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod Message-ID: <20150619081433.GR32730@opensource.wolfsonmicro.com> References: <1434638631-16451-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1434638631-16451-4-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 19, 2015 at 11:36:47AM +0900, Chanwoo Choi wrote: > Hi Charles, > > On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax > wrote: > > Convert to using the newer gpiod interface for the micd_pol_gpio. > > Although we still carry support for the old gpio interface from pdata. > > > > Signed-off-by: Charles Keepax > > --- > > + mode = GPIOD_OUT_HIGH; > > + else > > + mode = GPIOD_OUT_LOW; > > + > > + info->micd_pol_gpio = gpiod_get_optional(arizona->dev, > > + "wlf,micd-pol", > > + GPIOD_OUT_LOW); > > You can use the devm_gpiod_get_optional() to manage the system > resource automatically. > We can't actually use the devm call here, we need to pass arizona->dev as that is where the DT will reside, which is the device for the MFD. But if the devm is attached to the device for the MFD then it will not clear up when the extcon driver is unloaded. As such we have to do the put manually. I will look at respinning for the other comments. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod Date: Fri, 19 Jun 2015 09:14:33 +0100 Message-ID: <20150619081433.GR32730@opensource.wolfsonmicro.com> References: <1434638631-16451-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1434638631-16451-4-git-send-email-ckeepax@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org Cc: Lee Jones , "myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , Samuel Ortiz , devicetree , linux-kernel , patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Jun 19, 2015 at 11:36:47AM +0900, Chanwoo Choi wrote: > Hi Charles, > > On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax > wrote: > > Convert to using the newer gpiod interface for the micd_pol_gpio. > > Although we still carry support for the old gpio interface from pdata. > > > > Signed-off-by: Charles Keepax > > --- > > + mode = GPIOD_OUT_HIGH; > > + else > > + mode = GPIOD_OUT_LOW; > > + > > + info->micd_pol_gpio = gpiod_get_optional(arizona->dev, > > + "wlf,micd-pol", > > + GPIOD_OUT_LOW); > > You can use the devm_gpiod_get_optional() to manage the system > resource automatically. > We can't actually use the devm call here, we need to pass arizona->dev as that is where the DT will reside, which is the device for the MFD. But if the devm is attached to the device for the MFD then it will not clear up when the extcon driver is unloaded. As such we have to do the put manually. I will look at respinning for the other comments. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html