From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754689AbbFSJN5 (ORCPT ); Fri, 19 Jun 2015 05:13:57 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:56037 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754465AbbFSJNu (ORCPT ); Fri, 19 Jun 2015 05:13:50 -0400 Date: Fri, 19 Jun 2015 10:13:49 +0100 From: Charles Keepax To: cw00.choi@samsung.com Cc: Lee Jones , "myungjoo.ham@samsung.com" , Samuel Ortiz , devicetree , linux-kernel , patches@opensource.wolfsonmicro.com Subject: Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod Message-ID: <20150619091349.GU32730@opensource.wolfsonmicro.com> References: <1434638631-16451-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1434638631-16451-4-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20150619081433.GR32730@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 19, 2015 at 05:39:22PM +0900, Chanwoo Choi wrote: > On Fri, Jun 19, 2015 at 5:14 PM, Charles Keepax > wrote: > > On Fri, Jun 19, 2015 at 11:36:47AM +0900, Chanwoo Choi wrote: > >> Hi Charles, > >> > >> On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax > >> wrote: > >> > Convert to using the newer gpiod interface for the micd_pol_gpio. > >> > Although we still carry support for the old gpio interface from pdata. > >> > > >> > Signed-off-by: Charles Keepax > >> > --- > >> > + mode = GPIOD_OUT_HIGH; > >> > + else > >> > + mode = GPIOD_OUT_LOW; > >> > + > >> > + info->micd_pol_gpio = gpiod_get_optional(arizona->dev, > >> > + "wlf,micd-pol", > >> > + GPIOD_OUT_LOW); > >> > >> You can use the devm_gpiod_get_optional() to manage the system > >> resource automatically. > >> > > > > We can't actually use the devm call here, we need to pass > > arizona->dev as that is where the DT will reside, which is the > > device for the MFD. But if the devm is attached to the device for > > the MFD then it will not clear up when the extcon driver is > > unloaded. As such we have to do the put manually. > > > > I will look at respinning for the other comments. > > I don't understand. extcon-arizona.c used already following devm_* functions: > - devm_kzalloc() > - devm_regulator_get() > - devm_extcon_dev_*() > - devm_input_allocate_device() > - devm_gpio_request_one() Yes but if you look at those all of those are against &pdev->dev which is the extcon device. The gpiod interface expects the device passed to both contain the of_node and be used for the devm operations. But we need to use the extcon device for the devm operations, but the of_node is contained on the MFD device. So if I do: devm_gpiod_get_optional(arizona->dev, .... Then the gpiod won't be released when the extcon device is removed. But if I do: devm_gpiod_get_optional(&pdev->dev, .... Then it won't be able to find the DT entries. Thanks, Charles