From: Thomas Huth <thuth@redhat.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/6] vhost-net: tell tap backend about the vnet endianness
Date: Fri, 19 Jun 2015 11:16:35 +0200 [thread overview]
Message-ID: <20150619111635.1a37f6e2@thh440s> (raw)
In-Reply-To: <20150617132349.6560.80324.stgit@bahia.lab.toulouse-stg.fr.ibm.com>
Hi,
On Wed, 17 Jun 2015 15:23:49 +0200
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
> The default behaviour for TAP/MACVTAP is to consider vnet as native endian.
>
> This patch handles the cases when this is not true:
> - virtio 1.0: always little-endian
> - legacy cross-endian
>
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> ---
> hw/net/vhost_net.c | 33 ++++++++++++++++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index 1c55517e3611..8cbb2f618c1c 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
...
> @@ -365,6 +394,8 @@ void vhost_net_stop(VirtIODevice *dev, NetClientState *ncs,
> fflush(stderr);
> }
> assert(r >= 0);
> +
> + assert(vhost_net_set_vnet_endian(dev, ncs[0].peer, false) >= 0);
> }
Putting the vhost_net_set_vnet_endian() within the assert statement
looks somewhat wrong to me. assert() gets defined to nothing in case
NDEBUG is defined, so the call would then simply be dropped.
I guess you rather want something like this here:
r = vhost_net_set_vnet_endian(dev, ncs[0].peer, false);
assert(r >= 0);
?
Thomas
next prev parent reply other threads:[~2015-06-19 9:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 13:23 [Qemu-devel] [PATCH 0/6] vhost: cross-endian support Greg Kurz
2015-06-17 13:23 ` [Qemu-devel] [PATCH 1/6] linux-headers: sync vhost.h Greg Kurz
2015-06-17 13:23 ` [Qemu-devel] [PATCH 2/6] virtio: introduce virtio_legacy_is_cross_endian() Greg Kurz
2015-06-17 13:23 ` [Qemu-devel] [PATCH 3/6] vhost: set vring endianness for legacy virtio Greg Kurz
2015-06-17 13:23 ` [Qemu-devel] [PATCH 4/6] tap: add VNET_LE/VNET_BE operations Greg Kurz
2015-06-17 13:23 ` [Qemu-devel] [PATCH 5/6] vhost-net: tell tap backend about the vnet endianness Greg Kurz
2015-06-19 9:16 ` Thomas Huth [this message]
2015-06-19 9:45 ` Greg Kurz
2015-06-17 13:23 ` [Qemu-devel] [PATCH 6/6] vhost_net: re-enable when cross endian Greg Kurz
2015-06-17 15:10 ` [Qemu-devel] [PATCH 0/6] vhost: cross-endian support Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619111635.1a37f6e2@thh440s \
--to=thuth@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.