From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: vdso: work-around broken ELF toolchains in Makefile
Date: Fri, 19 Jun 2015 15:10:07 +0100 [thread overview]
Message-ID: <20150619141007.GB20798@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <1434718593-3648-1-git-send-email-will.deacon@arm.com>
On Fri, Jun 19, 2015 at 01:56:33PM +0100, Will Deacon wrote:
> When building the kernel with a bare-metal (ELF) toolchain, the -shared
> option may not be passed down to collect2, resulting in silent corruption
> of the vDSO image (in particular, the DYNAMIC section is omitted).
>
> The effect of this corruption is that the dynamic linker fails to find
> the vDSO symbols and libc is instead used for the syscalls that we
> intended to optimise (e.g. gettimeofday). Functionally, there is no
> issue as the sigreturn trampoline is still intact and located by the
> kernel.
>
> This patch fixes the problem by explicitly passing -shared to the linker
> when building the vDSO.
>
> Cc: <stable@vger.kernel.org>
> Reported-by: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
> Reported-by: James Greenlaigh <james.greenhalgh@arm.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Queued for 4.2. Thanks.
--
Catalin
next prev parent reply other threads:[~2015-06-19 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 12:56 [PATCH] arm64: vdso: work-around broken ELF toolchains in Makefile Will Deacon
2015-06-19 14:10 ` Catalin Marinas [this message]
2015-06-19 14:47 ` Nathan Lynch
2015-06-19 14:55 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619141007.GB20798@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.