From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH OSSTEST v3 02/11]
 mg-debian-installer-update: updates to better handle Jessie onwards.
Date: Fri, 19 Jun 2015 15:53:00 +0100
Message-ID: <20150619145300.GK28194@zion.uk.xensource.com>
References: <1434546404-2036-1-git-send-email-wei.liu2@citrix.com>
	<1434546404-2036-3-git-send-email-wei.liu2@citrix.com>
	<1434721834.28264.133.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=605a65143=wei.liu2@citrix.com>)
	id 1Z5xfF-00015o-9i
	for xen-devel@lists.xenproject.org; Fri, 19 Jun 2015 14:53:05 +0000
Content-Disposition: inline
In-Reply-To: <1434721834.28264.133.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wei.liu2@citrix.com>, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Fri, Jun 19, 2015 at 02:50:34PM +0100, Ian Campbell wrote:
> On Wed, 2015-06-17 at 14:06 +0100, Wei Liu wrote:
> > +case $suite_$arch in
> 
> Sorry, this is buggy, it looks for a variable named "suite_" which
> doesn't exist and so nothing matches. It needs this:
> 
> diff --git a/mg-debian-installer-update b/mg-debian-installer-update
> index b9b1146..6a26675 100755
> --- a/mg-debian-installer-update
> +++ b/mg-debian-installer-update
> @@ -102,7 +102,7 @@ done
>  # Some platforms require a newer kernel than is in Debian. Construct
>  # something suitable from the latest kernel ($bpok=flavour) in
>  # backports.
> -case $suite_$arch in
> +case ${suite}_${arch} in
>      wheezy_armhf) bpok=armmp; need_initramfs=y;;
>  esac
>  if [ x$bpok != x ]; then
> 

I folded this in.

Wei.

> Ian.