From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/atomic: Don't set crtc_state->enable manually Date: Fri, 19 Jun 2015 18:01:35 +0200 Message-ID: <20150619160135.GH25769@phenom.ffwll.local> References: <1434721315-4022-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by gabe.freedesktop.org (Postfix) with ESMTP id B531C6EF11 for ; Fri, 19 Jun 2015 08:58:50 -0700 (PDT) Received: by wgez8 with SMTP id z8so93298416wge.0 for ; Fri, 19 Jun 2015 08:58:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1434721315-4022-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Daniel Vetter , Daniel Stone , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdW4gMTksIDIwMTUgYXQgMDQ6NDE6NTVQTSArMDMwMCwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiBUaGUgZW5hYmxlIGZpZWxkIG5lZWRzIHRvIGJlIGtlcHQgaW4gc3luYyB3aXRo IHRoZSBtb2RlX2Jsb2IgZmllbGQuIENhbGwKPiBkcm1fYXRvbWljX3NldF9tb2RlX3Byb3BfZm9y X2NydGMoKSBpbnN0ZWFkIG9mIHNldHRpbmcgZW5hYmxlIHRvIGZhbHNlCj4gaW4gb3JkZXIgdG8g ZGVyZWZlcmVuY2UgdGhlIG1vZGUgYmxvYiBjb3JyZWN0bHkuCj4gCj4gU2lnbmVkLW9mZi1ieTog TGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlkZWFzb25ib2FyZC5j b20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIHwgMTAgKysr KysrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygt KQo+IAo+IEFub3RoZXIgb3B0aW9uIHdvdWxkIGJlIHRvIG9wZW4tY29kZSB0aGUgbW9kZSBibG9i IHVucmVmZXJlbmNlIGluCj4gdXBkYXRlX291dHB1dF9zdGF0ZSgpLiBJJ20gbm90IHN1cmUgd2hh dCdzIGJlc3QuCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hl bHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBpbmRleCA1MzZh ZTRkYTQ2NjUuLjY0Yzc1YWYxYzA4OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pY19oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBl ci5jCj4gQEAgLTE1NTQsNiArMTU1NCw4IEBAIHN0YXRpYyBpbnQgdXBkYXRlX291dHB1dF9zdGF0 ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gIAl9Cj4gIAo+ICAJZm9yX2VhY2hf Y3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0ZSwgaSkgewo+ICsJCXVuc2lnbmVk IGludCBudW1fY29ubmVjdG9yczsKPiArCj4gIAkJLyogRG9uJ3QgdXBkYXRlIC0+ZW5hYmxlIGZv ciB0aGUgQ1JUQyBpbiB0aGUgc2V0X2NvbmZpZyByZXF1ZXN0LAo+ICAJCSAqIHNpbmNlIGEgbWlz bWF0Y2ggd291bGQgaW5kaWNhdGUgYSBidWcgaW4gdGhlIHVwcGVyIGxheWVycy4KPiAgCQkgKiBU aGUgYWN0dWFsIG1vZGVzZXQgY29kZSBsYXRlciBvbiB3aWxsIGNhdGNoIGFueQo+IEBAIC0xNTYx LDEwICsxNTYzLDEyIEBAIHN0YXRpYyBpbnQgdXBkYXRlX291dHB1dF9zdGF0ZShzdHJ1Y3QgZHJt X2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gIAkJaWYgKGNydGMgPT0gc2V0LT5jcnRjKQo+ICAJCQlj b250aW51ZTsKPiAgCj4gLQkJY3J0Y19zdGF0ZS0+ZW5hYmxlID0KPiAtCQkJZHJtX2F0b21pY19j b25uZWN0b3JzX2Zvcl9jcnRjKHN0YXRlLCBjcnRjKTsKPiAtCQlpZiAoIWNydGNfc3RhdGUtPmVu YWJsZSkKPiArCQludW1fY29ubmVjdG9ycyA9IGRybV9hdG9taWNfY29ubmVjdG9yc19mb3JfY3J0 YyhzdGF0ZSwgY3J0Yyk7Cj4gKwkJaWYgKCFudW1fY29ubmVjdG9ycykgewo+ICsJCQlyZXQgPSBk cm1fYXRvbWljX3NldF9tb2RlX3Byb3BfZm9yX2NydGMoY3J0Y19zdGF0ZSwKPiArCQkJCQkJCQlO VUxMKTsKCnJldCBzZWVtcyBsb3N0IGhlcmUgYmVjYXVzZSBvZiB0aGUgcmV0dXJuIDA7IGJlbG93 LgotRGFuaWVsCgo+ICAJCQljcnRjX3N0YXRlLT5hY3RpdmUgPSBmYWxzZTsKPiArCQl9Cj4gIAl9 Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gLS0gCj4gUmVnYXJkcywKPiAKPiBMYXVyZW50IFBpbmNoYXJ0 Cj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRp b24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK