From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH OSSTEST v3 12/11] toolstack/libvirt: install libnl-3-200 on Jessie Date: Fri, 19 Jun 2015 17:13:59 +0100 Message-ID: <20150619161358.GM28194@zion.uk.xensource.com> References: <1434546404-2036-1-git-send-email-wei.liu2@citrix.com> <1434644826-22381-1-git-send-email-wei.liu2@citrix.com> <21892.1443.343849.772897@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z5yww-0008Hk-9f for xen-devel@lists.xenproject.org; Fri, 19 Jun 2015 16:15:26 +0000 Content-Disposition: inline In-Reply-To: <21892.1443.343849.772897@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Xen-devel , Wei Liu , ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, Jun 19, 2015 at 01:05:55PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH OSSTEST v3 12/11] toolstack/libvirt: install libnl-3-200 on Jessie"): > > Signed-off-by: Wei Liu > ... > > diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm > > index e7f4860..c71f88a 100644 > > --- a/Osstest/Toolstack/libvirt.pm > > +++ b/Osstest/Toolstack/libvirt.pm > > @@ -24,11 +24,15 @@ use Osstest::TestSupport; > > > > sub new { > > my ($class, $ho, $methname,$asset) = @_; > > + my @extra_packages = qw(libavahi-client3); > > + my $nl_lib = "libnl-3-200"; > > + $nl_lib = "libnl1" if ($ho->{Suite} =~ m/wheezy/); > > + push(@extra_packages, $nl_lib); > > return bless { Name => "libvirt", > > Host => $ho, > > NewDaemons => [qw(libvirtd)], > > Dom0MemFixed => 1, > > - ExtraPackages => [qw(libnl1 libavahi-client3)], > > + ExtraPackages => [@extra_packages], > > It would be more normal to write > \@extra_packages > rather than > [@extra_packages] > unless you actually need to make a copy of the array. > > (I don't care about this for efficiency, but rather for readability: > writing [@extra_packages] carries an implication that something might > edit either @extra_packages or ExtraPackages afterwards. > For the record, Ian acked the following updated patch on IRC. ---8<--- >>From b422cb2c6c1ecdc62a5a46212f2cf648c2141509 Mon Sep 17 00:00:00 2001 From: Wei Liu Date: Thu, 18 Jun 2015 15:46:07 +0100 Subject: [PATCH OSSTEST] toolstack/libvirt: install libnl-3-200 on Jessie Cc: ian.campbell@citrix.com, ian.jackson@eu.citrix.com Signed-off-by: Wei Liu Acked-by: Ian Jackson --- Osstest/Toolstack/libvirt.pm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm index e7f4860..51a10de 100644 --- a/Osstest/Toolstack/libvirt.pm +++ b/Osstest/Toolstack/libvirt.pm @@ -24,11 +24,15 @@ use Osstest::TestSupport; sub new { my ($class, $ho, $methname,$asset) = @_; + my @extra_packages = qw(libavahi-client3); + my $nl_lib = "libnl-3-200"; + $nl_lib = "libnl1" if ($ho->{Suite} =~ m/wheezy/); + push(@extra_packages, $nl_lib); return bless { Name => "libvirt", Host => $ho, NewDaemons => [qw(libvirtd)], Dom0MemFixed => 1, - ExtraPackages => [qw(libnl1 libavahi-client3)], + ExtraPackages => \@extra_packages, }, $class; } -- 1.9.1