From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C50961C105E for ; Fri, 19 Jun 2015 19:12:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C0A06A43AA for ; Fri, 19 Jun 2015 19:12:03 +0000 (UTC) Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A1mtOHUrshDY for ; Fri, 19 Jun 2015 19:12:03 +0000 (UTC) Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 355C9A4423 for ; Fri, 19 Jun 2015 19:12:03 +0000 (UTC) Date: Fri, 19 Jun 2015 22:11:27 +0300 From: Dan Carpenter Subject: Re: [PATCH v2 2/3] staging: unisys: convert pack pragma to __packed Message-ID: <20150619191127.GG30834@mwanda> References: <1434141968-4133-1-git-send-email-david.kershner@unisys.com> <1434141968-4133-3-git-send-email-david.kershner@unisys.com> <20150619125513.GP28762@mwanda> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: "Kershner, David A" Cc: "gregkh@linuxfoundation.org" , "Romer, Benjamin M" , *S-Par-Maintainer , "driverdev-devel@linuxdriverproject.org" , "Jes.Sorensen@redhat.com" On Fri, Jun 19, 2015 at 03:02:32PM +0000, Kershner, David A wrote: > Thanks for the find. Unfortunately, all the structs defined in iochannel.h > need to be packed since they are shared across different OS and code > instances. I'll look into changing the s-Par firmware and will update the > iochannels structure as well. > > Your reference to x86, does that include x86_64? Yes. I just it up on google so I don't know if it makes a difference here. http://stackoverflow.com/questions/3057452/misaligned-pointer-performance regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel