* Cavium Liquidio: select on undefined option LIBCRC32
@ 2015-06-12 11:26 Valentin Rothberg
2015-06-16 23:51 ` [PATCH net-next] Modify Liquidio Kconfig for crc lib Raghu Vatsavayi
0 siblings, 1 reply; 4+ messages in thread
From: Valentin Rothberg @ 2015-06-12 11:26 UTC (permalink / raw
To: rvatsavayi
Cc: linux-kernel, Paul Bolle, Andreas Ruprecht, hengelein Stefan,
netdev, davem, derek.chickles, satananda.burla, felix.manlunas,
Robert.Richter, Aleksey.Makarov
Hi Raghu,
your commit f21fb3ed364b ("Add support of Cavium Liquidio ethernet
adapters") is in today's linux-next tree (i.e., next-20150612) adding
the following lines of code:
+config LIQUIDIO
[...]
+ select LIBCRC32
The select turns out to be a NOOP since there is no option LIBCRC32.
I guess it's a typo and the correct option is LIBCRC32C?
Is there a patch queued somewhere to fix the issue?
I detected the issue with ./scripts/checkkconfigsymbols.py.
Kind regards,
Valentin
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next] Modify Liquidio Kconfig for crc lib
2015-06-12 11:26 Cavium Liquidio: select on undefined option LIBCRC32 Valentin Rothberg
@ 2015-06-16 23:51 ` Raghu Vatsavayi
2015-06-21 16:51 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Raghu Vatsavayi @ 2015-06-16 23:51 UTC (permalink / raw
To: davem
Cc: netdev, valentinrothberg, Raghu Vatsavayi, Derek Chickles,
Satanand Burla, Felix Manlunas, Raghu Vatsavayi
Following patch contains changes in liquidio Kconfig for
selecting LIBCRC32C.
Signed-off-by: Derek Chickles <derek.chickles@caviumnetworks.com>
Signed-off-by: Satanand Burla <satananda.burla@caviumnetworks.com>
Signed-off-by: Felix Manlunas <felix.manlunas@caviumnetworks.com>
Signed-off-by: Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks.com>
---
drivers/net/ethernet/cavium/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cavium/Kconfig b/drivers/net/ethernet/cavium/Kconfig
index 5e7a0e2..c4d6bbe 100644
--- a/drivers/net/ethernet/cavium/Kconfig
+++ b/drivers/net/ethernet/cavium/Kconfig
@@ -46,7 +46,7 @@ config LIQUIDIO
depends on 64BIT
select PTP_1588_CLOCK
select FW_LOADER
- select LIBCRC32
+ select LIBCRC32C
---help---
This driver supports Cavium LiquidIO Intelligent Server Adapters
based on CN66XX and CN68XX chips.
--
1.8.4.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] Modify Liquidio Kconfig for crc lib
2015-06-16 23:51 ` [PATCH net-next] Modify Liquidio Kconfig for crc lib Raghu Vatsavayi
@ 2015-06-21 16:51 ` David Miller
2015-06-22 4:32 ` Vatsavayi, Raghu
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2015-06-21 16:51 UTC (permalink / raw
To: rvatsavayi
Cc: netdev, valentinrothberg, derek.chickles, satananda.burla,
felix.manlunas, raghu.vatsavayi
From: Raghu Vatsavayi <rvatsavayi@caviumnetworks.com>
Date: Tue, 16 Jun 2015 16:51:43 -0700
> Following patch contains changes in liquidio Kconfig for
> selecting LIBCRC32C.
>
> Signed-off-by: Derek Chickles <derek.chickles@caviumnetworks.com>
> Signed-off-by: Satanand Burla <satananda.burla@caviumnetworks.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@caviumnetworks.com>
> Signed-off-by: Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH net-next] Modify Liquidio Kconfig for crc lib
2015-06-21 16:51 ` David Miller
@ 2015-06-22 4:32 ` Vatsavayi, Raghu
0 siblings, 0 replies; 4+ messages in thread
From: Vatsavayi, Raghu @ 2015-06-22 4:32 UTC (permalink / raw
To: David Miller
Cc: netdev@vger.kernel.org, valentinrothberg@gmail.com,
Chickles, Derek, Burla, Satananda, Manlunas, Felix
Thanks Much Dave.
Regards
Raghu
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Sunday, June 21, 2015 9:52 AM
> To: Vatsavayi, Raghu
> Cc: netdev@vger.kernel.org; valentinrothberg@gmail.com; Chickles, Derek;
> Burla, Satananda; Manlunas, Felix; Vatsavayi, Raghu
> Subject: Re: [PATCH net-next] Modify Liquidio Kconfig for crc lib
>
> From: Raghu Vatsavayi <rvatsavayi@caviumnetworks.com>
> Date: Tue, 16 Jun 2015 16:51:43 -0700
>
> > Following patch contains changes in liquidio Kconfig for selecting
> > LIBCRC32C.
> >
> > Signed-off-by: Derek Chickles <derek.chickles@caviumnetworks.com>
> > Signed-off-by: Satanand Burla <satananda.burla@caviumnetworks.com>
> > Signed-off-by: Felix Manlunas <felix.manlunas@caviumnetworks.com>
> > Signed-off-by: Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks.com>
>
> Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-22 4:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-12 11:26 Cavium Liquidio: select on undefined option LIBCRC32 Valentin Rothberg
2015-06-16 23:51 ` [PATCH net-next] Modify Liquidio Kconfig for crc lib Raghu Vatsavayi
2015-06-21 16:51 ` David Miller
2015-06-22 4:32 ` Vatsavayi, Raghu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.