From: David Miller <davem@davemloft.net>
To: kraig@google.com
Cc: netdev@vger.kernel.org, edumazet@google.com
Subject: Re: [PATCH net-next] sock_diag: fetch source port from inet_sock
Date: Sun, 21 Jun 2015 10:17:32 -0700 (PDT) [thread overview]
Message-ID: <20150621.101732.640058888707620388.davem@davemloft.net> (raw)
In-Reply-To: <1434553150-8750-1-git-send-email-kraig@google.com>
From: Craig Gallek <kraig@google.com>
Date: Wed, 17 Jun 2015 10:59:10 -0400
> When an inet_sock is destroyed, its source port (sk_num) is set to
> zero as part of the unhash procedure. In order to supply a source
> port as part of the NETLINK_SOCK_DIAG socket destruction broadcasts,
> the source port number must be read from inet_sport instead.
>
> Tested: ss -E
> Signed-off-by: Craig Gallek <kraig@google.com>
Applied but it seems very hackish and not very long term maintainable
to do things this way.
prev parent reply other threads:[~2015-06-21 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 14:59 [PATCH net-next] sock_diag: fetch source port from inet_sock Craig Gallek
2015-06-21 17:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150621.101732.640058888707620388.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kraig@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.