From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753804AbbFXOQ3 (ORCPT ); Wed, 24 Jun 2015 10:16:29 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:33111 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753142AbbFXOQX (ORCPT ); Wed, 24 Jun 2015 10:16:23 -0400 Date: Wed, 24 Jun 2015 15:16:17 +0100 From: Lee Jones To: Charles Keepax Cc: cw00.choi@samsung.com, myungjoo.ham@samsung.com, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH v3 7/7] mfd: arizona: Update several pdata members to unsigned Message-ID: <20150624141617.GO15013@x1> References: <1434709467-28147-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1434709467-28147-8-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1434709467-28147-8-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Jun 2015, Charles Keepax wrote: > Device tree and ACPI primarily deal with unsigned ints, many of the > pdata members in the Arizona driver are signed ints but are only ever > assigned positive values. Changing these pdata fields to unsigned ints > avoids us having to choose between overly verbose code and Sparse > warnings. > > Signed-off-by: Charles Keepax > --- > include/linux/mfd/arizona/pdata.h | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) Applied for v4.3, thanks. > diff --git a/include/linux/mfd/arizona/pdata.h b/include/linux/mfd/arizona/pdata.h > index af44081..f2c8381 100644 > --- a/include/linux/mfd/arizona/pdata.h > +++ b/include/linux/mfd/arizona/pdata.h > @@ -104,7 +104,7 @@ struct arizona_pdata { > * useful for systems where and I2S bus with multiple data > * lines is mastered. > */ > - int max_channels_clocked[ARIZONA_MAX_AIF]; > + unsigned int max_channels_clocked[ARIZONA_MAX_AIF]; > > /** GPIO5 is used for jack detection */ > bool jd_gpio5; > @@ -128,22 +128,22 @@ struct arizona_pdata { > unsigned int hpdet_channel; > > /** Extra debounce timeout used during initial mic detection (ms) */ > - int micd_detect_debounce; > + unsigned int micd_detect_debounce; > > /** GPIO for mic detection polarity */ > int micd_pol_gpio; > > /** Mic detect ramp rate */ > - int micd_bias_start_time; > + unsigned int micd_bias_start_time; > > /** Mic detect sample rate */ > - int micd_rate; > + unsigned int micd_rate; > > /** Mic detect debounce level */ > - int micd_dbtime; > + unsigned int micd_dbtime; > > /** Mic detect timeout (ms) */ > - int micd_timeout; > + unsigned int micd_timeout; > > /** Force MICBIAS on for mic detect */ > bool micd_force_micbias; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog