From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2 08/11] hash: add new functionality to store data in hash table Date: Mon, 29 Jun 2015 21:36:53 -1000 Message-ID: <20150629213653.5ba8388d@uryu.home.lan> References: <1433514804-7075-1-git-send-email-pablo.de.lara.guarch@intel.com> <1435269919-7007-1-git-send-email-pablo.de.lara.guarch@intel.com> <1435269919-7007-9-git-send-email-pablo.de.lara.guarch@intel.com> <20150626094955.4a999f79@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: "De Lara Guarch, Pablo" Return-path: Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id AEC775FEB for ; Tue, 30 Jun 2015 09:36:59 +0200 (CEST) Received: by pdbep18 with SMTP id ep18so1440023pdb.1 for ; Tue, 30 Jun 2015 00:36:59 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 28 Jun 2015 22:23:28 +0000 "De Lara Guarch, Pablo" wrote: > Hi Stephen, > > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Friday, June 26, 2015 5:50 PM > > To: De Lara Guarch, Pablo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2 08/11] hash: add new functionality to > > store data in hash table > > > > We did same thing with a slightly different method. > > > > Subject: rte_hash: split key and bucket size > > > > It is useful to store more data in the has bucket than just the key size. > > For example, storing an addresss and additional data. > > > > Signed-off-by: Stephen Hemminger > > Did you send this patch? I did not see it in the mailing list... > Anyway, I like the idea of allowing the user to store variable size data (I was storing 8-byte data). > So I have sent a v3 with a more similar method, although I still use the new functions, > and use the parameter data_len for knowing the amount of bytes of data, and I keep constant the input key, > and return the data in another parameter. > > Thanks for it! > Pablo I did not send the patch upstream because it would break the ABI and didn't want to bother fighting that.