From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752080AbbGARie (ORCPT ); Wed, 1 Jul 2015 13:38:34 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35313 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbbGARiZ (ORCPT ); Wed, 1 Jul 2015 13:38:25 -0400 Date: Wed, 1 Jul 2015 18:38:02 +0100 From: Mark Brown To: Tomeu Vizoso Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, "Rafael J. Wysocki" , alsa-devel@alsa-project.org, Jaroslav Kysela , Thierry Reding , Takashi Iwai , Stephen Warren , Liam Girdwood , linux-tegra@vger.kernel.org, Alexandre Courbot Message-ID: <20150701173802.GW11162@sirena.org.uk> References: <1435743667-11987-1-git-send-email-tomeu.vizoso@collabora.com> <1435743667-11987-12-git-send-email-tomeu.vizoso@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TcuvTDpCAASXpu1W" Content-Disposition: inline In-Reply-To: <1435743667-11987-12-git-send-email-tomeu.vizoso@collabora.com> X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --TcuvTDpCAASXpu1W Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote: > +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode, > + struct list_head *deps) > +{ > + add_dependency(fwnode, "nvidia,i2s-controller", deps); > + add_dependency(fwnode, "nvidia,audio-codec", deps); > +} Why is this all being open coded in an individual driver (we already know about and manage all these dependencies in the core...)? If we're going to do this I'd expect the interface for specifying DT nodes to the core to be changed to support this. --TcuvTDpCAASXpu1W Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVlCV6AAoJECTWi3JdVIfQ9sQH/07qCQICx8rYy7I6jC+6lWam k0oQM1iJtoGIzxrnjZ3kPkumKA1N/p1bXAx3NVcmrD7KcOhALqe50qpheQ+CmVOZ LYAhUrbBYuPUBBqd9hsT7ZfLnAM9/jHCI04ch/Z8qo2khMwXmPPcm4tQeijJLLki dpvepRs8pRozlpKkQroJJQ1zleI/D64IxnqRbKauI+3MPBxyZeUe9ozjZI8VjxWq 7N/AUIKachCgud0DNxjtdmsNMh6teCXQeV5YOGqcOsFHXQodpiRozw+2/As5N/Te fllk/BbgQInsWyI9MG0D69+KvSgNkBB+k4YODNzV7AKYE3IqKxJdDP+C+HKeubg= =TvF/ -----END PGP SIGNATURE----- --TcuvTDpCAASXpu1W-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Wed, 01 Jul 2015 17:38:02 +0000 Subject: Re: [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes Message-Id: <20150701173802.GW11162@sirena.org.uk> MIME-Version: 1 Content-Type: multipart/mixed; boundary="TcuvTDpCAASXpu1W" List-Id: References: <1435743667-11987-1-git-send-email-tomeu.vizoso@collabora.com> <1435743667-11987-12-git-send-email-tomeu.vizoso@collabora.com> In-Reply-To: <1435743667-11987-12-git-send-email-tomeu.vizoso@collabora.com> To: Tomeu Vizoso Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, "Rafael J. Wysocki" , alsa-devel@alsa-project.org, Jaroslav Kysela , Thierry Reding , Takashi Iwai , Stephen Warren , Liam Girdwood , linux-tegra@vger.kernel.org, Alexandre Courbot --TcuvTDpCAASXpu1W Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote: > +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode, > + struct list_head *deps) > +{ > + add_dependency(fwnode, "nvidia,i2s-controller", deps); > + add_dependency(fwnode, "nvidia,audio-codec", deps); > +} Why is this all being open coded in an individual driver (we already know about and manage all these dependencies in the core...)? If we're going to do this I'd expect the interface for specifying DT nodes to the core to be changed to support this. --TcuvTDpCAASXpu1W Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVlCV6AAoJECTWi3JdVIfQ9sQH/07qCQICx8rYy7I6jC+6lWam k0oQM1iJtoGIzxrnjZ3kPkumKA1N/p1bXAx3NVcmrD7KcOhALqe50qpheQ+CmVOZ LYAhUrbBYuPUBBqd9hsT7ZfLnAM9/jHCI04ch/Z8qo2khMwXmPPcm4tQeijJLLki dpvepRs8pRozlpKkQroJJQ1zleI/D64IxnqRbKauI+3MPBxyZeUe9ozjZI8VjxWq 7N/AUIKachCgud0DNxjtdmsNMh6teCXQeV5YOGqcOsFHXQodpiRozw+2/As5N/Te fllk/BbgQInsWyI9MG0D69+KvSgNkBB+k4YODNzV7AKYE3IqKxJdDP+C+HKeubg= =TvF/ -----END PGP SIGNATURE----- --TcuvTDpCAASXpu1W--