From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753448AbbGCI6B (ORCPT ); Fri, 3 Jul 2015 04:58:01 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:36122 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754648AbbGCI5y (ORCPT ); Fri, 3 Jul 2015 04:57:54 -0400 Date: Fri, 3 Jul 2015 14:27:49 +0530 From: Viresh Kumar To: Stefan Agner Cc: Thomas Gleixner , Daniel Lezcano , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jingchang Lu , Shawn Guo Subject: Re: [PATCH 39/41] clocksource: vf_pit: Migrate to new 'set-state' interface Message-ID: <20150703085749.GE23297@linux> References: <19859bd18fb69fa1f10c07de01b2259d@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19859bd18fb69fa1f10c07de01b2259d@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03-07-15, 10:10, Stefan Agner wrote: > > .features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT, > > - .set_mode = pit_set_mode, > > + .set_state_shutdown = pit_shutdown, > > + .set_state_periodic = pit_set_periodic, > > I'm not really familiar with the interface, but given that we announce > the feature CLOCK_EVT_FEAT_ONESHOT shouldn't we add a set_state_oneshot > callback here? We weren't doing anything in pit_set_mode(ONESHOT) and so that callback is not implemented. In case you need to do something in set_state_oneshot(), we can add it back. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@linaro.org (Viresh Kumar) Date: Fri, 3 Jul 2015 14:27:49 +0530 Subject: [PATCH 39/41] clocksource: vf_pit: Migrate to new 'set-state' interface In-Reply-To: <19859bd18fb69fa1f10c07de01b2259d@agner.ch> References: <19859bd18fb69fa1f10c07de01b2259d@agner.ch> Message-ID: <20150703085749.GE23297@linux> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03-07-15, 10:10, Stefan Agner wrote: > > .features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT, > > - .set_mode = pit_set_mode, > > + .set_state_shutdown = pit_shutdown, > > + .set_state_periodic = pit_set_periodic, > > I'm not really familiar with the interface, but given that we announce > the feature CLOCK_EVT_FEAT_ONESHOT shouldn't we add a set_state_oneshot > callback here? We weren't doing anything in pit_set_mode(ONESHOT) and so that callback is not implemented. In case you need to do something in set_state_oneshot(), we can add it back. -- viresh