From: Greg KH <greg@kroah.com>
To: Jiri Kosina <jkosina@suse.com>
Cc: ksummit-discuss@lists.linuxfoundation.org
Subject: Re: [Ksummit-discuss] [CORE TOPIC] services needed from kernel.org infrastructure
Date: Wed, 8 Jul 2015 07:59:10 -0700 [thread overview]
Message-ID: <20150708145910.GA11945@kroah.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1507080957360.10183@pobox.suse.cz>
On Wed, Jul 08, 2015 at 10:02:36AM +0200, Jiri Kosina wrote:
> On Tue, 7 Jul 2015, Greg KH wrote:
>
> > > > Those are useful, I know Greg has one and I just wrote one too. I'm not
> > > > sure it needs to be on the server side though, they can also be done
> > > > from the client which lets you try to fine tune things more readily.
> > >
> > > If either of you could share the scripts that would be great.
> >
> > Mine is based on Andrew's scripts, and can be found buried in my
> > "gregkh-linux" repo which is a shadow of my 'linux/' subdir on my
> > development machines, specifically this file:
> > https://github.com/gregkh/gregkh-linux/blob/master/work/do.sh
>
> Well, I think you've nicely demonstrated the reason why I think there
> should be a central machinery; perhaps as a stanard open-source project,
> i.e reviewed, contributed to, and shared by everybody.
>
> The "everybody has his home-brew hacked-up script" model is just
> unnecessary duplication of work a brings potential for unnecessary bugs.
>
> For example, please correct me if I am wrong, but I believe that if I send
> you a patch that would have authorship
>
> Jiri Kosina <jkosina`rm -rf .`@suse.com>
>
> and you wouldn't notice prior to applying it using the above do.sh, I
> think your precious tree is gone.
Note, I don't have "precious" trees, nor "precious" development systems,
that's what git is for :)
But you are right in that this isn't good, and Andrew's scripts also
have the same bug as mine are based on his. But this isn't a matter of
them not being open, both of ours have been published publicly for over
a decade.
Every 6 months or so I start to rewrite the script to use a "proper"
email address parser library, and give up. I guess now I have to do it
for real, thanks for giving me a reason to do so.
> This would be caught immediately if it's properly maintained "project".
Hm, ok, but different maintainers have different needs. James's git
hooks are also really nice, and work for some workflows (note, I use
them for some stable workflows). Wolfram has published his scripts that
he uses for applying and testing patches in the past as well, and while
they were great for him, they didn't fit mine at the time.
So given 4 different maintainers, all of whom have posted their tools,
all of them are different given different methods of working. Creating
one set of tools might be a bit hard based on this tiny sample size
already...
But, I'm willing to try, and clean up my mess, I'll work on making my
scripts "work robustly" and publish them and take feedback. Ideally I
can tie them into the stable patch review process as well, as I know
others have been asking for those scripts to be unified into something
that someone other than me can get working.
thanks,
greg k-h
next prev parent reply other threads:[~2015-07-08 14:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 20:42 [Ksummit-discuss] [CORE TOPIC] services needed from kernel.org infrastructure Jiri Kosina
2015-07-07 22:40 ` Mark Brown
2015-07-07 22:52 ` Dmitry Torokhov
2015-07-08 2:16 ` Greg KH
2015-07-08 8:02 ` Jiri Kosina
2015-07-08 9:35 ` Mark Brown
2015-07-08 14:01 ` Theodore Ts'o
2015-07-08 14:36 ` Jason Cooper
2015-07-08 14:40 ` Jiri Kosina
2015-07-08 15:00 ` Greg KH
2015-07-12 12:55 ` Fengguang Wu
2015-07-13 16:22 ` Steven Rostedt
2015-07-14 13:07 ` Fengguang Wu
2015-07-08 14:59 ` Greg KH [this message]
2015-07-08 15:08 ` Jiri Kosina
2015-07-08 15:42 ` Steven Rostedt
2015-07-07 22:53 ` josh
2015-07-08 7:35 ` Jiri Kosina
2015-07-08 13:05 ` Jason Cooper
2015-07-07 23:31 ` Andy Lutomirski
2015-07-07 23:37 ` Guenter Roeck
2015-07-07 23:38 ` Andy Lutomirski
2015-07-08 8:01 ` Geert Uytterhoeven
2015-07-08 7:31 ` James Bottomley
2015-07-08 13:25 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150708145910.GA11945@kroah.com \
--to=greg@kroah.com \
--cc=jkosina@suse.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.