From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964958AbbGHSAd (ORCPT ); Wed, 8 Jul 2015 14:00:33 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:33354 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758380AbbGHSA1 (ORCPT ); Wed, 8 Jul 2015 14:00:27 -0400 Date: Wed, 8 Jul 2015 19:00:20 +0100 From: Matt Fleming To: Kees Cook Cc: Yinghai Lu , "H. Peter Anvin" , Baoquan He , LKML Subject: Re: [PATCH 28/42] x86, boot: Allow 64bit EFI kernel to be loaded above 4G Message-ID: <20150708180020.GC5598@codeblueprint.co.uk> References: <1436300428-21163-1-git-send-email-yinghai@kernel.org> <1436300428-21163-29-git-send-email-yinghai@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Jul, at 04:12:26PM, Kees Cook wrote: > > @@ -301,7 +301,7 @@ _start: > > # Part 2 of the header, from the old setup.S > > > > .ascii "HdrS" # header signature > > - .word 0x020d # header version number (>= 0x0105) > > + .word 0x020e # header version number (>= 0x0105) > > # or else old loadlin-1.5 will fail) > > .globl realmode_swtch > > realmode_swtch: .word 0, 0 # default_switch, SETUPSEG > > @@ -478,6 +478,7 @@ pref_address: .quad LOAD_PHYSICAL_ADDR # preferred load addr > > #endif > > init_size: .long INIT_SIZE # kernel initialization size > > handover_offset: .long 0 # Filled in by build.c > > +ext_code32_start: .long 0 # werid one! > > Comment is a typo? Yeah, this was one of the things I pointed out the last time this patch was sent and it's disheartening to see it wasn't fixed (as trivial as it may be), https://lkml.kernel.org/r/20150224215501.GB9758@codeblueprint.co.uk -- Matt Fleming, Intel Open Source Technology Center