From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: socfpga: put back v7_invalidate_l1 in socfpga_secondary_startup
Date: Thu, 9 Jul 2015 11:52:49 +0800 [thread overview]
Message-ID: <20150709115249.18fefe8d@xhacker> (raw)
In-Reply-To: <20150708210734.GN7557@n2100.arm.linux.org.uk>
Dear Russell,
On Wed, 8 Jul 2015 22:07:34 +0100
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Wed, Jul 08, 2015 at 02:13:32PM -0500, Dinh Nguyen wrote:
> > The value of CPACR is 0x00F00000. So cp11 and cp10 are privileged and
> > user mode access.
>
> Hmm.
>
> I think what you've found is a(nother) latent bug in the CPU bring up
> code.
>
> For SMP CPUs, the sequence we're following during early initialisation is:
>
> 1. Enable SMP coherency.
> 2. Invalidate the caches.
>
> If the cache contains rubbish, enabling SMP coherency before invalidating
> the cache is plainly an absurd thing to do.
>
> Can you try the patch below - not tested in any way, so you may need to
> tweak it, but it should allow us to prove that point.
>
> diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
> index 0716bbe19872..db5137fc297d 100644
> --- a/arch/arm/mm/proc-v7.S
> +++ b/arch/arm/mm/proc-v7.S
> @@ -275,6 +275,10 @@ __v7_b15mp_setup:
> __v7_ca17mp_setup:
> mov r10, #0
> 1:
> + adr r12, __v7_setup_stack @ the local stack
> + stmia r12, {r0-r5, r7, r9-r11, lr}
> + bl v7_invalidate_l1
> + ldmia r12, {r0-r5, r7, r9-r11, lr}
Some CPUs such as CA7 need enable SMP before any cache maintenance.
CA7 TRM says something about SMP bit:
"You must ensure this bit is set to 1 before the caches and MMU are enabled,
or any cache and TLB maintenance operations are performed."
So it seems we need to use different path for different CPUs.
Also CA7 would invalidate L1 automatically once reset, can we remove the
invalidate op in CA7 case?
I'm not sure I understand the code correctly, criticism is welcome.
Thanks,
Jisheng
> #ifdef CONFIG_SMP
> ALT_SMP(mrc p15, 0, r0, c1, c0, 1)
> ALT_UP(mov r0, #(1 << 6)) @ fake it for UP
> @@ -283,7 +287,7 @@ __v7_ca17mp_setup:
> orreq r0, r0, r10 @ Enable CPU-specific SMP bits
> mcreq p15, 0, r0, c1, c0, 1
> #endif
> - b __v7_setup
> + b __v7_setup_cont
>
> /*
> * Errata:
> @@ -417,6 +421,7 @@ __v7_setup:
> bl v7_invalidate_l1
> ldmia r12, {r0-r5, r7, r9, r11, lr}
>
> +__v7_setup_cont:
> and r0, r9, #0xff000000 @ ARM?
> teq r0, #0x41000000
> bne __errata_finish
> @@ -480,7 +485,7 @@ ENDPROC(__v7_setup)
>
> .align 2
> __v7_setup_stack:
> - .space 4 * 11 @ 11 registers
> + .space 4 * 12 @ 12 registers
>
> __INITDATA
>
next prev parent reply other threads:[~2015-07-09 3:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 15:51 [PATCH] ARM: socfpga: put back v7_invalidate_l1 in socfpga_secondary_startup dinguyen at opensource.altera.com
2015-07-08 16:51 ` Russell King - ARM Linux
2015-07-08 19:13 ` Dinh Nguyen
2015-07-08 21:07 ` Russell King - ARM Linux
2015-07-08 21:55 ` Dinh Nguyen
2015-07-09 3:52 ` Jisheng Zhang [this message]
2015-07-09 7:57 ` Russell King - ARM Linux
2015-07-09 8:17 ` Jisheng Zhang
2015-07-14 12:15 ` Dinh Nguyen
2015-07-15 19:04 ` Russell King - ARM Linux
2015-07-15 20:11 ` Dinh Nguyen
2015-07-15 19:23 ` Dinh Nguyen
2015-07-16 16:11 ` Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709115249.18fefe8d@xhacker \
--to=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.