From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 1/4] eal: provide functions to access PCI config Date: Thu, 9 Jul 2015 14:08:32 -0700 Message-ID: <20150709140832.570e77f3@urahara> References: <1434498700-8522-1-git-send-email-stephen@networkplumber.org> <1434498700-8522-2-git-send-email-stephen@networkplumber.org> <513c51e29ab6449c99ae70c77e72566c@BRMWP-EXMB11.corp.brocade.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Stephen Hemminger To: David Marchand Return-path: Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) by dpdk.org (Postfix) with ESMTP id 0D70C5A68 for ; Thu, 9 Jul 2015 23:08:24 +0200 (CEST) Received: by pdrg1 with SMTP id g1so39575759pdr.2 for ; Thu, 09 Jul 2015 14:08:23 -0700 (PDT) In-Reply-To: <513c51e29ab6449c99ae70c77e72566c@BRMWP-EXMB11.corp.brocade.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 17 Jun 2015 14:44:31 +0000 David Marchand wrote: > +=C2=A0 =C2=A0 =C2=A0 =C2=A0if (len =3D=3D 3 || len > sizeof(pi.pi_data))= { > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0RTE_LOG(ERR, EAL,= "%s(): invalid pci read length\n", __func__); > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0goto error; > +=C2=A0 =C2=A0 =C2=A0 =C2=A0} >=20 > A comment on length 3 would help to understand why it is refused. PCI only supports 1, 2, and 4 byte transactions. Hopefully someone using this would understand that.