* [RFC] i2c-tools: allow linker and compile flags from command line
@ 2015-06-19 9:24 Wolfram Sang
[not found] ` <1434705872-2866-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2015-06-19 9:24 UTC (permalink / raw
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Jean Delvare; +Cc: Wolfram Sang
Mainly for debugging, so one can pass stuff like -O0 or -static.
Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
---
tools/Module.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/Module.mk b/tools/Module.mk
index 8efddbb..641ac81 100644
--- a/tools/Module.mk
+++ b/tools/Module.mk
@@ -9,13 +9,13 @@
TOOLS_DIR := tools
-TOOLS_CFLAGS := -Wstrict-prototypes -Wshadow -Wpointer-arith -Wcast-qual \
+TOOLS_CFLAGS += -Wstrict-prototypes -Wshadow -Wpointer-arith -Wcast-qual \
-Wcast-align -Wwrite-strings -Wnested-externs -Winline \
-W -Wundef -Wmissing-prototypes -Iinclude
ifeq ($(USE_STATIC_LIB),1)
-TOOLS_LDFLAGS := $(LIB_DIR)/$(LIB_STLIBNAME)
+TOOLS_LDFLAGS += $(LIB_DIR)/$(LIB_STLIBNAME)
else
-TOOLS_LDFLAGS := -Llib -li2c
+TOOLS_LDFLAGS += -Llib -li2c
endif
TOOLS_TARGETS := i2cdetect i2cdump i2cset i2cget
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1434705872-2866-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]
* Re: [RFC] i2c-tools: allow linker and compile flags from command line [not found] ` <1434705872-2866-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> @ 2015-07-07 19:08 ` Jean Delvare [not found] ` <20150707210828.0e5caf05-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Jean Delvare @ 2015-07-07 19:08 UTC (permalink / raw To: Wolfram Sang; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA Hi Wolfram, On Fri, 19 Jun 2015 11:24:32 +0200, Wolfram Sang wrote: > Mainly for debugging, so one can pass stuff like -O0 or -static. > > Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> > --- > tools/Module.mk | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/Module.mk b/tools/Module.mk > index 8efddbb..641ac81 100644 > --- a/tools/Module.mk > +++ b/tools/Module.mk > @@ -9,13 +9,13 @@ > > TOOLS_DIR := tools > > -TOOLS_CFLAGS := -Wstrict-prototypes -Wshadow -Wpointer-arith -Wcast-qual \ > +TOOLS_CFLAGS += -Wstrict-prototypes -Wshadow -Wpointer-arith -Wcast-qual \ > -Wcast-align -Wwrite-strings -Wnested-externs -Winline \ > -W -Wundef -Wmissing-prototypes -Iinclude > ifeq ($(USE_STATIC_LIB),1) > -TOOLS_LDFLAGS := $(LIB_DIR)/$(LIB_STLIBNAME) > +TOOLS_LDFLAGS += $(LIB_DIR)/$(LIB_STLIBNAME) > else > -TOOLS_LDFLAGS := -Llib -li2c > +TOOLS_LDFLAGS += -Llib -li2c Note that -Llib has become -L$(LIB_DIR) meanwhile. > endif > > TOOLS_TARGETS := i2cdetect i2cdump i2cset i2cget You can already overwrite CFLAGS and LDFLAGS on the command line, and this works for the whole package. Do you really need to set different CFLAGS (or LDFLAGS) for different parts of i2c-tools? Seems overkill to me. If you really need that then this should be done consistently for all "modules": not just tools but also lib and now eeprog. -- Jean Delvare SUSE L3 Support ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20150707210828.0e5caf05-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>]
* Re: [RFC] i2c-tools: allow linker and compile flags from command line [not found] ` <20150707210828.0e5caf05-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> @ 2015-07-09 16:50 ` Wolfram Sang 0 siblings, 0 replies; 3+ messages in thread From: Wolfram Sang @ 2015-07-09 16:50 UTC (permalink / raw To: Jean Delvare; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 300 bytes --] > You can already overwrite CFLAGS and LDFLAGS on the command line, and > this works for the whole package. Do you really need to set different > CFLAGS (or LDFLAGS) for different parts of i2c-tools? Seems overkill to > me. I agree, not really needed now. Let's skip this one. Thanks, Wolfram [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-09 16:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-19 9:24 [RFC] i2c-tools: allow linker and compile flags from command line Wolfram Sang
[not found] ` <1434705872-2866-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-07-07 19:08 ` Jean Delvare
[not found] ` <20150707210828.0e5caf05-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2015-07-09 16:50 ` Wolfram Sang
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.